mirror of
https://github.com/nerfstudio-project/nerfstudio.git
synced 2026-11-13 19:33:46 +08:00
Remove unused make_share_url arg in ns-viewer (#2749)
* Remove unused make_share_url arg in ns-viewer * Update docstring * Ruff --------- Co-authored-by: Justin Kerr <justin.g.kerr@gmail.com>
This commit is contained in:
1 parent
32939e0d41
commit
609dc3ea5e
2 files changed
+1
-4
No files matched your search
@@ -147,7 +147,7 @@ class ViewerConfig(PrintableConfig):
|
||||
jpeg_quality: int = 75
|
||||
"""Quality tradeoff to use for jpeg compression."""
|
||||
make_share_url: bool = False
|
||||
"""Viewer beta feature: print a shareable URL. `vis` must be set to viewer_beta; this flag is otherwise ignored."""
|
||||
"""Viewer beta feature: print a shareable URL. This flag is ignored in the legacy version of the viewer."""
|
||||
camera_frustum_scale: float = 0.1
|
||||
"""Scale for the camera frustums in the viewer."""
|
||||
default_composite_depth: bool = True
|
||||
|
||||
@@ -55,8 +55,6 @@ class RunViewer:
|
||||
"""Viewer configuration"""
|
||||
vis: Literal["viewer", "viewer_legacy"] = "viewer"
|
||||
"""Type of viewer"""
|
||||
make_share_url: bool = True
|
||||
"""Print a shareable URL"""
|
||||
|
||||
def main(self) -> None:
|
||||
"""Main function."""
|
||||
@@ -68,7 +66,6 @@ class RunViewer:
|
||||
num_rays_per_chunk = config.viewer.num_rays_per_chunk
|
||||
assert self.viewer.num_rays_per_chunk == -1
|
||||
config.vis = self.vis
|
||||
config.viewer.make_share_url = self.make_share_url
|
||||
config.viewer = self.viewer.as_viewer_config()
|
||||
config.viewer.num_rays_per_chunk = num_rays_per_chunk
|
||||
|
||||
|
||||
Reference in new issue
Block a user