From 609dc3ea5e3f8b2b2821c2076918d52140d478e3 Mon Sep 17 00:00:00 2001 From: Brent Yi Date: Tue, 16 Jan 2024 16:08:18 -0800 Subject: [PATCH] Remove unused make_share_url arg in ns-viewer (#2749) * Remove unused make_share_url arg in ns-viewer * Update docstring * Ruff --------- Co-authored-by: Justin Kerr --- nerfstudio/configs/base_config.py | 2 +- nerfstudio/scripts/viewer/run_viewer.py | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/nerfstudio/configs/base_config.py b/nerfstudio/configs/base_config.py index 85c205c5c..f5ffddda9 100644 --- a/nerfstudio/configs/base_config.py +++ b/nerfstudio/configs/base_config.py @@ -147,7 +147,7 @@ class ViewerConfig(PrintableConfig): jpeg_quality: int = 75 """Quality tradeoff to use for jpeg compression.""" make_share_url: bool = False - """Viewer beta feature: print a shareable URL. `vis` must be set to viewer_beta; this flag is otherwise ignored.""" + """Viewer beta feature: print a shareable URL. This flag is ignored in the legacy version of the viewer.""" camera_frustum_scale: float = 0.1 """Scale for the camera frustums in the viewer.""" default_composite_depth: bool = True diff --git a/nerfstudio/scripts/viewer/run_viewer.py b/nerfstudio/scripts/viewer/run_viewer.py index 63c2007fb..79e7167f3 100644 --- a/nerfstudio/scripts/viewer/run_viewer.py +++ b/nerfstudio/scripts/viewer/run_viewer.py @@ -55,8 +55,6 @@ class RunViewer: """Viewer configuration""" vis: Literal["viewer", "viewer_legacy"] = "viewer" """Type of viewer""" - make_share_url: bool = True - """Print a shareable URL""" def main(self) -> None: """Main function.""" @@ -68,7 +66,6 @@ class RunViewer: num_rays_per_chunk = config.viewer.num_rays_per_chunk assert self.viewer.num_rays_per_chunk == -1 config.vis = self.vis - config.viewer.make_share_url = self.make_share_url config.viewer = self.viewer.as_viewer_config() config.viewer.num_rays_per_chunk = num_rays_per_chunk