Merge branch 'main' into update-scheduler

nerfstudio/model_components/renderers.py

@@ -180,7 +180,7 @@ class SHRenderer(nn.Module):
         components = components_from_spherical_harmonics(levels=levels, directions=directions)
 
         rgb = sh * components[..., None, :]  # [..., num_samples, 3, sh_components]
-        rgb = torch.sum(sh, dim=-1) + 0.5  # [..., num_samples, 3]
+        rgb = torch.sum(rgb, dim=-1)  # [..., num_samples, 3]
 
         if self.activation is not None:
             rgb = self.activation(rgb)

nerfstudio/process_data/hloc_utils.py

@@ -117,7 +117,13 @@ def run_hloc(
         camera_model=camera_model.value
     )
     if refine_pixsfm:
-        sfm = PixSfM({"dense_features": {"max_edge": 1024}})
+        sfm = PixSfM(
+            conf={
+                "dense_features": {"use_cache": True},
+                "KA": {"dense_features": {"use_cache": True}, "max_kps_per_problem": 1000},
+                "BA": {"strategy": "costmaps"},
+            }
+        )
         refined, _ = sfm.reconstruction(
             sfm_dir,
             image_dir,

nerfstudio/process_data/realitycapture_utils.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Helper utils for processing polycam data into the nerfstudio format."""
+"""Helper utils for processing reality capture data into the nerfstudio format."""
 
 import csv
 import json

tests/model_components/test_renderers.py

@@ -40,7 +40,7 @@ def test_sh_renderer():
     sh_renderer = renderers.SHRenderer()
 
     rgb = sh_renderer(sh=sh, directions=directions, weights=weights)
-    assert torch.max(rgb) > 0.9
+    assert torch.max(rgb) > 0.7
 
 
 def test_acc_renderer():