From 4145f010d2269c996f68163f9883d996b71547d3 Mon Sep 17 00:00:00 2001
From: Pythonix Huang <370048201@qq.com>
Date: Mon, 27 Mar 2023 11:33:54 +0800
Subject: [PATCH 1/3] Update pixsfm with better param (#1661)

Previous setting will easily go to oom
---
 nerfstudio/process_data/hloc_utils.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/nerfstudio/process_data/hloc_utils.py b/nerfstudio/process_data/hloc_utils.py
index 6ec71edd0..f04f6c32c 100644
--- a/nerfstudio/process_data/hloc_utils.py
+++ b/nerfstudio/process_data/hloc_utils.py
@@ -117,7 +117,13 @@ def run_hloc(
         camera_model=camera_model.value
     )
     if refine_pixsfm:
-        sfm = PixSfM({"dense_features": {"max_edge": 1024}})
+        sfm = PixSfM(
+            conf={
+                "dense_features": {"use_cache": True},
+                "KA": {"dense_features": {"use_cache": True}, "max_kps_per_problem": 1000},
+                "BA": {"strategy": "costmaps"},
+            }
+        )
         refined, _ = sfm.reconstruction(
             sfm_dir,
             image_dir,

From 35cd06ef363287d9efd02521516f852b0563985e Mon Sep 17 00:00:00 2001
From: henrypearce4D <106480554+henrypearce4D@users.noreply.github.com>
Date: Mon, 27 Mar 2023 15:26:13 +0100
Subject: [PATCH 2/3] Update realitycapture_utils.py (#1663)

corrected the description from polycam data to reality capture data
---
 nerfstudio/process_data/realitycapture_utils.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nerfstudio/process_data/realitycapture_utils.py b/nerfstudio/process_data/realitycapture_utils.py
index 4bc02417e..918aa84a5 100644
--- a/nerfstudio/process_data/realitycapture_utils.py
+++ b/nerfstudio/process_data/realitycapture_utils.py
@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Helper utils for processing polycam data into the nerfstudio format."""
+"""Helper utils for processing reality capture data into the nerfstudio format."""
 
 import csv
 import json

From 24b3db8eb068ba21cea4c5bd617d67e10240fdbc Mon Sep 17 00:00:00 2001
From: wang shuai <212106734@qq.com>
Date: Tue, 28 Mar 2023 22:58:21 +0800
Subject: [PATCH 3/3] Fix bug: sh render is not correct (#1667)

* Update renderers.py

revise the SH renderer

* Update test_renderers.py

change the test target for sh render
---
 nerfstudio/model_components/renderers.py | 2 +-
 tests/model_components/test_renderers.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/nerfstudio/model_components/renderers.py b/nerfstudio/model_components/renderers.py
index 5e488bc35..43f81404c 100644
--- a/nerfstudio/model_components/renderers.py
+++ b/nerfstudio/model_components/renderers.py
@@ -180,7 +180,7 @@ class SHRenderer(nn.Module):
         components = components_from_spherical_harmonics(levels=levels, directions=directions)
 
         rgb = sh * components[..., None, :]  # [..., num_samples, 3, sh_components]
-        rgb = torch.sum(sh, dim=-1) + 0.5  # [..., num_samples, 3]
+        rgb = torch.sum(rgb, dim=-1)  # [..., num_samples, 3]
 
         if self.activation is not None:
             rgb = self.activation(rgb)
diff --git a/tests/model_components/test_renderers.py b/tests/model_components/test_renderers.py
index 984a45e7c..a1e098388 100644
--- a/tests/model_components/test_renderers.py
+++ b/tests/model_components/test_renderers.py
@@ -40,7 +40,7 @@ def test_sh_renderer():
     sh_renderer = renderers.SHRenderer()
 
     rgb = sh_renderer(sh=sh, directions=directions, weights=weights)
-    assert torch.max(rgb) > 0.9
+    assert torch.max(rgb) > 0.7
 
 
 def test_acc_renderer():