Commit Graph
1569 Commits
Author SHA1 Message Date
henrypearce4D d01fef7650 Fix metashape multiple camera models error message (#2057)
Reverted back to the original error message with some extra clarification added.

cc #2011
2023-06-09 15:09:13 -07:00
jMysliwiecandJakub Mysliwiec 5511f5f4ed Quick fix for eval script failing for depth-nerfacto (and other methods with a non-standard dataset) (#2047)
dirty fix for the eval_utils script that fails because generics don't work with yaml configs

Co-authored-by: Jakub Mysliwiec <jmysliwiec@cyclomedia.com>
2023-06-08 08:22:46 -07:00
Jonáš Kulhánek 3b0f7581d8 Reduce GPU memory usage in CacheDataloader (#1730)
* Reduce GPU memory usage in CacheDataloader

* Move also masks and seg.masks, depths to cpu

* Fix linter issues
2023-06-07 14:14:24 -04:00
Matias Turkulainen d4b04376ab Fix bug when copying images when input_dir = output_dir (#2041)
* fixes bug input_dir == output_dir

* reformat
2023-06-07 10:22:10 -07:00
koju Bishad 43c399e71e Fix Typo on colab file (#2039)
Fix Typo
2023-06-05 09:56:07 -07:00
Cameron FandMatthew Tancik 42081b7ad4 Add option for model normals on ply export (#1965)
* Update point cloud exporter to accept the same arguments as the poisson mesh export wrt normals + hoist validate pipeline up so both exporters can use it

* Update viewer to support both normal methods for point cloud and poisson export

* Lint fixes

* Undo eslint comments

* Add types and documentation for args in validate pipeline function

---------

Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-06-04 22:38:32 -04:00
893730fa05 installation.md: Use https instead of ssh for git clone. (#2030)
* installation.md: Use https instead of ssh for git clone.

Https git clone can be run by anyone directly, without account, whereas ssh git on Github requires having a Github account set up.

* Add .git

---------

Co-authored-by: Matthew Tancik <mattt4001@gmail.com>
Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-06-04 19:23:12 -07:00
Matias Turkulainen 742dfd96a7 Add antialias parameter as default None (#2033)
add antialias parameter as default None
2023-06-04 19:19:18 -07:00
henrypearce4D 293d8f3811 Update metashape_utils.py (#2011)
Changed the ValueError message when using a camera.xml that contains multiple sensors. Per-frame intrinsics can be defined, the previous message said that they were not supported.
2023-06-01 23:44:08 -07:00
Alexander Kristoffersen 24d02515a9 Colab update to Python 3.10 (#2017)
* updated colab to 310

* update to py310
2023-05-30 17:03:18 -07:00
Jonáš Kulhánek a0d5307dd7 [WIP] Fix model loading collate_fn non-static (#1990)
* Fix model loading collate_fn non-static

* Fix serialization

* Add tests to reproduce the error

* Comment the change to let the tests fail

* Finish changes
2023-05-29 00:56:41 -07:00
Mingwu ZhengandMatthew Tancik ba08a8f530 Add Metadata Handling to Cameras Collation Function (#2001)
* Add metadata collate for cameras

* checks passed

---------

Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-05-27 21:00:40 +00:00
Brent Yi 4d71cd2e95 Bump tyro (#2008) 2023-05-27 19:49:11 +00:00
Cyrus Vachha 6993f75dc8 Render Omni-directional stereo video (360 3D VR) (#1986)
* Render Omni-directional stereo (360 3D VR)

Adding the omni-directional stereo camera model to render 3D 360 video and images for VR. This includes the camera models for the left and right eyes and additions to the render script to stack the left and right renders for the final render.
I have also updated the documentation on the custom_dataset page to have information on ODS but let me know if there is a better place to put it.

* Updated ODS camera model and render paths

Updates based on suggested code changes including adding a helper function for ODS and improving path creation.
I also added a part where if a user tries to render a video with an output path that doesn't have an extension it will automatically add .mp4 to the end. Otherwise this usually results in an error when there is no file extension when rendering a video.

* Updated formatting for render and cam path scripts

Updated python formatting for render and camera_paths script

* Adding type checking for ODS function and reformatting camera type code

Added the type checking and doc string for the ODS camera rays function and reformatted the cam_type ray if statements.
2023-05-26 18:01:13 -07:00
Matthew Tancik addf477e8c add controls to the beta viewer (#2005)
* add controls to the beta viewer

* Remove misc file

* works now
2023-05-26 15:15:36 -07:00
Jonáš Kulhánek 9643c1ece2 Fixes wandb runs resuming using WANDB_RUN_ID (#2004) 2023-05-26 10:29:26 +02:00
Ethan WeberandEthan Weber bb6925bac6 Ability to use vanilla pytorch instead of tcnn for Nerfacto (#1936)
* started a package to easily swap out tcnn for pytorch

* trains with pytorch and not tcnn

* cleaned up imports

* making it easy to install on mac

* removed/reverted files

* merged main

* reverted changes

* updating config

* starting to add nerfacto to tests

* fixxing default value

* fixed default implementation

* defaults to torch if tcnn and not installed

* update log

* add comment

* resolved pr comments

* fix

* update default

---------

Co-authored-by: Ethan Weber <ethanweber@eecs-128-32-175-250.dhcp.berkeley.edu>
2023-05-25 14:55:42 -07:00
Matthew Tancik 400ab5a313 Fix exponential decay warmup (#2002)
Fix exponendial decay warmup
2023-05-25 10:07:22 -07:00
Terrance WangandMatthew Tancik a8bce87ada pass grad scaler from trainer to pipeline (#1996)
* pass grad sclaer from trainer to pipeline

* lint

* add grad scaler to arg doc

---------

Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-05-25 09:27:58 -07:00
f9a88c5aa2 add deepfloyd model (#1993)
* add deepfloyd model

* black

* lint

* linting

* cast sds gradient to tensor

* change generator type to optional

* lint

* Type fixes

* add typing to sds

---------

Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
Co-authored-by: Matt Tancik <mattt4001@gmail.com>
2023-05-25 00:14:04 -07:00
Ethan Weber e94d9031ab SIGGRAPH 2023 Citation Update (#1997)
* siggraph 2023 update

* update citation

* update citation
2023-05-24 18:16:01 -07:00
Matthew Tancik 45395efa1c Fix viewer decorator (#1995) 2023-05-24 14:46:43 -07:00
Saurav Maheshkar 46bc8fe7cc style(ruff): provide better integration with ruff vscode extension (#1994)
* style(ruff): use default python setttings

* style(ruff): add ruff extension to `devcontainer.json`
2023-05-24 12:22:02 -07:00
Matthew Tancik 76165fcd02 Fix custom dataparser docs (#1991)
Update new_methods.md
2023-05-24 11:18:35 -07:00
Lukas Hoellein eaa4f91913 Fix Viewer Recursion: StackOverflow in Server Setup (#1987)
fix viewer recursion
2023-05-24 10:03:50 -07:00
Sophus 3a31da36f7 fix visualize encoding bug (#1984) 2023-05-24 10:01:22 -07:00
dependabot[bot] 160abde6ad Bump socket.io-parser from 4.2.1 to 4.2.3 in /nerfstudio/viewer/app (#1983)
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.1 to 4.2.3.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io-parser/compare/4.2.1...4.2.3)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-05-23 20:08:50 -07:00
Matias TurkulainenandMatthew Tancik 33d95f3e71 Added at_train_end logic to base pipeline (#1932)
* process additional images

* added on_train_end to base pipeline

* added on_train_end to base pipeline

* remove on_train_end from Base Model and Base Datamanager

* Add new callback type OnTrainEndCallback

* return empty list as default

* add on_train_end to trainingcallbacklocation enum

* make step var into union of int and None

* after train end callback

* Delete unnecessary file

* Delete unnecessary file

* Delete unnecessary file

---------

Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-05-23 16:03:55 -07:00
Jonáš Kulhánek 61e48108df Add warnings for (slower) Torch 1.x and Windows not supporting torch.compile (#1982)
Add warning for torch 1.x and windows
2023-05-23 15:18:53 -07:00
Matthew Tancik efd83abb6d Basic viser frontend (#1973)
* Use viser frontend

* Rendering but poses incorrect

* Fix cameras
2023-05-23 12:21:38 -07:00
Milan van Wouden d413ca4204 fix large number of typos in repository (#1977)
* fix large number of typos in repository

* fix typos in tests
2023-05-23 10:41:49 -07:00
Daniel Crispell ccdcc3951e generalize mask collation to other image-like data (#1959) 2023-05-22 18:10:39 -07:00
Matthew Tancik a90602060b Update installation docs (#1970)
* Update installation docs

* Update instructions

* Make tcnn consistent
2023-05-22 17:39:32 -07:00
Matthew Tancik bd04ceeb50 v0.3.1 (#1972) v0.3.1 2023-05-22 10:45:32 -07:00
Lukas Hoellein d8f2446122 Fix mask check in PatchPixelSampler (#1971)
* fix mask check in PatchPixelSampler

* change torch.Tensor to Tensor
2023-05-22 10:43:14 -07:00
Matthew Tancik 27e2c874cb Report tcnn import errors (#1969) 2023-05-22 09:36:00 -07:00
Jonáš Kulhánekandmachenmusik 3bc160cc7d Backward compatibility for torch 1.x and fix for windows (#1962)
* backward compatibility for torch 1.x and fix for windows

* Update pyproject.toml

* Update README.md

* Update README.md

(As per request)

---------

Co-authored-by: machenmusik <machenmusik@users.noreply.github.com>
2023-05-22 08:58:08 -07:00
Matthew Tancik c86ae8a07f Update render docstring (#1960) 2023-05-19 09:27:45 -07:00
Matthew Tancik b6093e2414 Update demo.ipynb
Fix ns-render
2023-05-19 08:59:34 -07:00
Matthew Tancik 1e205c1b5b Remove hloc from pyproejct (#1955) 2023-05-18 17:45:11 -07:00
Matthew Tancik a4775f218f v0.3.0 (#1954) v0.3.0 2023-05-18 17:37:04 -07:00
Justin KerrandChung Min Kim 0ee63cb581 Expose viewer controls to pipeline (#1804)
* Increase max_res of first proposal network

* start on ViewerCamera

* crop controls exposed

* lint

* fix viewer crash when invisible element has its value set

* fov, look_at, and camera type

* stuff

* set update interval correctly in cameracontrols, smooth transitions work now

* demo with depth zooming

* depth min

* WIP adding click message

* put the clock back in viewerwindow

* use setlookat when pos and target are defined at the same time

* remove demo from nerfacto

* Add click commands as rays (origin, direction)

* short doc

* Fix double event for doubleclick

* add ViewerClick, cleanup docs

* add docs

* cleanup

* remove scripts

* remove nerfacto changes

* js compile things

* update viewer version

* fix mutable state thing

* docs improvements

* add kwarg value for enableTransition

* fix

* lint

* path in sync-defs

* Misc doc edits requested in pr

* Add click description

* WIP remove redefinition of banner_height, refer to SCSS vars

* add docstring

* radix

* radix

* speed

---------

Co-authored-by: Chung Min Kim <chungmin99@gmail.com>
2023-05-18 17:36:00 -07:00
bb9d89cd23 output jpg option and progress bar (#1896)
* CropParamsMessage

* output jpg and show frame count

* --image-format and --jpeg-quality

---------

Co-authored-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-05-18 16:31:07 -07:00
Matthew Tancik 8f4f89cf87 Don't run temporal tv loss test (#1952) 2023-05-18 16:03:25 -07:00
Jonáš KulhánekandBrent Yi 9584fa9b39 Add pre-commit (#1949)
* Add pre-commit

* Add pre-commit to docs

---------

Co-authored-by: Brent Yi <yibrenth@gmail.com>
2023-05-18 07:13:58 -07:00
Matthew TancikandBrent Yi 2b0831b6d4 Final typing fixes + add Pyright to CI (#1944)
* knocking out a couple

* Fix more errors

* Add pyright

* Remove some unnecessary cv2 type ignores, warning on missing imports
(for missing tinycudann)

* Minor annotation fixes

* Update docs

* Drop `None` from temporal distortion output

---------

Co-authored-by: Brent Yi <yibrenth@gmail.com>
2023-05-18 02:25:34 -07:00
Jonáš Kulhánek 08e3a1f1a6 Drop backward compatibility for Torch 1.13 (#1948)
* Drop backward compatibility for Torch 1.13

* Fix lint errors
2023-05-18 09:12:51 +02:00
Jonáš Kulhánek ea3f25d662 Bump torchvision to match PyTorch (#1947)
Bump torchvision to match torch
2023-05-17 22:45:28 -07:00
Matthew Tancik e0e48bcecd Update SD for pytorch 2 (#1943) 2023-05-17 17:47:03 -07:00
Jonáš KulhánekandBrent Yi f481f5ebec Fix some typing problems (#1940)
* Fix some typing problems

* nerfstudio.data typing error fixes

* Add tiny fixes

* Remove ABC from pipeline

* Prevent circular imports

* Tweak ModuleList typing

* TrainingCallbackAttributes cleanup

* Various minor nits

* More nits

* Run `ruff`

---------

Co-authored-by: Brent Yi <yibrenth@gmail.com>
2023-05-17 17:36:56 -07:00