Commit Graph
1136 Commits
Author SHA1 Message Date
Tao 1a70665e76 Fix slow training issue when using mask (#1114) 2022-12-13 10:16:34 -08:00
Nikhil Mohan 98f13cbed4 Fix circular imports (#1115)
* wip

* remove bad changes

* update dmeo

* cleanup

* change name

* cleanup
2022-12-13 10:09:31 -08:00
Alexander Kristoffersen 986f3a565d Colab working with Python3.8 (#1109)
changed away from the wheel, couldn't get it to work
2022-12-12 11:47:09 -08:00
Matthew Tancik 910e7bfb05 v0.1.13 (#1107) v0.1.13 2022-12-11 13:05:03 -08:00
Matthew Tancik 676f816156 Bump max res default (#1106) 2022-12-11 13:03:35 -08:00
Matthew Tancik b41ce8060a Save out dataparser transforms (#1105)
* Save out dataparser transforms

* Make missing folder
2022-12-11 13:02:50 -08:00
François Darmon 90447ab223 Bug correction auto_orient_and_center_poses (#1098)
When using auto_orient_and_center_poses with method="none" the returned pose if 4x4 (contrary to up and pca) which triggers an assertion error later. This modification solves it.
2022-12-07 09:40:53 -08:00
ksnzh e605b3344a Fix IndexError if ther is no mask filenames (#1095) 2022-12-05 22:10:55 -08:00
Matthew Tancik 006703bb64 Fix crash on camera delete (#1094) 2022-12-05 17:35:12 -08:00
Nicolas ZunhammerandNicolas Zunhammer 6896028fc5 Fix mask filenames misaligned after splitting set into train and eval (#1093)
* Added Dockerfile to build docker image including all dependencies and nerfstudio, added description on how to user docker.

* Move docker description to Installation.md.

* Fix mask_filename indices after splitting train set.

Co-authored-by: Nicolas Zunhammer <n.zunhammer@tum.de>
2022-12-05 17:04:40 -08:00
machenmusik f3442c8b7b Use max resolution when not moving or training (#1091)
use max resolution when not moving or training
2022-12-05 16:03:09 -08:00
Ethan Weber 2a62d8a14e Update mipnerf defaults (#1092)
update mipnerf defaults
2022-12-05 15:37:49 -08:00
Sandros94 13fca7044c 'get docker' typo (#1089)
Just a typo fix about 'get docker'.
2022-12-05 14:39:56 -08:00
Matthew Tancik 7265cb63af Metashape parsing fix (#1084) 2022-12-04 16:47:52 -08:00
RandomPrototypesandRandomPrototypes 740cdebbb5 WIP : support for hloc toolbox (superpoint, superglue, netvlad,...) (#1026)
* basic support for hloc (includes netvlad, super point, superglue in colmap), just a first test, not ready yet

* add exhaustive match option for hloc

* add command line option to choose the type of feature, matcher,...

* make hloc an optional dependency, update doc, and small bug fixes

* fix missing imports

* fix warnings, pylint,...

* fix overwrite previous commits

* fix import order from isort

* move find_tool_feature_matcher_combination to process_data_utils, add type hints and Args/Returns doc

* error message when no valid combination of sfm tool, feature type, and matcher

Co-authored-by: RandomPrototypes <delmotte_ar@yahoo.fr>
2022-12-03 22:45:48 -08:00
Ethan Weber f6ac1d72ff v0.1.12 (#1079) v0.1.12 2022-12-02 18:22:26 -08:00
Ethan Weber fc347d40d4 quick ui fix 2022-12-03 01:55:17 +00:00
Ethan Weber 3377c5344b [WIP] Mesh export UI (#1076)
* starting PR

* export mesh ui functional

* better descriptions
2022-12-02 17:51:21 -08:00
Ethan WeberandMatt Tancik 1052fccec2 Mesh export (#809)
* start of mesh PR

* point cloud export mvp

* start of mesh PR

* point cloud export mvp

* Save out mesh. Poor quality atm

* reorganized mesh algorithms and specified CLI

* CLI reorg

* tsdf algorithm in progress

* debugging

* tsdf functional but camera distortion params not in

* playing with distortion params

* TSDF works but texture looks bad

* added trimesh

* moved to exporter

* removed files

* saving progress

* save texture image

* seems to work w/o barycentric

* barycentric start

* gap between triangles

* blocking out diagonal

* new barcentric and scaling

* meshing working. need to remove extra rows

* fixed triangle packing

* gitignore changes

* removed package

* fix Literal import

* comments

* update .mtl file

* poisson mesh with model output normals & resolved some PR comments on git

* starting docs. breaking up big function. todo: add xatlas

* xatlas and nvdiffrast working

* triangle_id

* progress on expensive texture coordinates method

* pytorch meshing works

* removing nvdiffrast

* remove trimesh

* cleanup

* few changes

* pred normals by default and add minimum additions to viewer

* fix cli in viewer

* add xatlas as dependency

* make point cloud more dense

* reverted viewer changes

* turn off normals by default

* fix docs

* finished todos on github

* remove xatlas

* xatlas

* black

Co-authored-by: Matt Tancik <tancik@berkeley.edu>
2022-12-02 10:49:19 -08:00
machenmusik d9395f2576 limit semantic-nerfw iterations to 30000 (#1074)
Per discussion at https://github.com/nerfstudio-project/nerfstudio/issues/1072#issuecomment-1334644896
2022-12-01 23:45:30 -08:00
Alexander DemidkoandAlexander Demidko bcbddf42d6 Interpolation config for tcnn hashgrid (#1058)
* Interpolation config for tcnn hashgrid

* Fixed ns-dev-test issues

Co-authored-by: Alexander Demidko <ademidko@matterport.com>
2022-12-01 07:38:38 -08:00
Brent Yi c2ad46d60e More informative completion install error messages (#1068)
More informative completion install errors
2022-12-01 07:36:41 -08:00
Mustafa Berk YALDIZ 1437a2fad5 Dnerf viewer and training fix (#1065)
* dnerf viewer and training fix

* Update viewer_utils.py
2022-11-30 23:07:21 -08:00
hturki 8c3f093ecb Fix device mismatch error when using masks (#1061)
* Fix device mismatch error when using masks

* Update pixel_samplers.py
2022-11-30 23:06:23 -08:00
machenmusik 4c6cd352d8 Make friends_dataparser path separator agnostic (fixes #1066) (#1067)
Make friends_dataparser path separator agnostic
2022-11-30 23:00:25 -08:00
machenmusik 533abb7d2f Fix IndexError runtime error (#1057)
* Fix IndexError runtime error

fixes this error:

  File "C:\code\nerfstudio\nerfstudio\data\dataparsers\nerfstudio_dataparser.py", line 232, in _generate_dataparser_outputs
    distortion_params = torch.stack(distort, dim=0)[idx_tensor]
IndexError: tensors used as indices must be long, byte or bool tensors

* Update nerfstudio_dataparser.py

Per discussion at https://github.com/nerfstudio-project/nerfstudio/pull/1057#issuecomment-1332670064
2022-11-30 15:50:48 -08:00
Matthew Tancik 4f1319fde4 Fix metashape labels (#1060) 2022-11-30 12:14:11 -08:00
Kevin Chen 5adbef8cf6 Fix torch spherical harmonics (#1054) 2022-11-29 20:35:35 -08:00
Ethan Weber 7346f97590 Quick fix to viewer OOM issue (#1053)
quick fix to viewer
2022-11-29 13:53:16 -08:00
Matthew Tancik 7280541350 Add per frame polycam intrinsics (#1050)
Add per frame polycam intrinsincs
2022-11-28 22:24:35 -08:00
Matthew Tancik a1f20b3ed8 Add per frame intrinsic support to nerfstudio data (#1049) 2022-11-28 22:13:55 -08:00
Kevin Chen 87c3ead680 Add Support for Equirectangular Images (#966) 2022-11-28 21:29:02 -08:00
Julian Knodt 1d10e047c2 add render time in viewer (#1007)
* Add temporary render for viewer

* Add slider for render time
2022-11-28 17:17:54 -08:00
Matthew Tancik 666b43a577 Check is metashape xml is present (#1044) 2022-11-28 16:39:09 -08:00
Matthew Tancik 6c805b6d33 v0.1.11 (#1043) v0.1.11 2022-11-28 15:16:54 -08:00
Matthew Tancik bce963facc Allow users to skip using openrelay (#1042) 2022-11-28 14:55:43 -08:00
Frédéric Devernay 8fc7950719 Fix benchmarking scripts (#1005)
* launch_eval_blender.sh: fix script

- add shebang
- add -s option to launch a single job per GPU
- last GPU was ignored
- kill all subprocesses when script is terminated

* launch_train_blender.sh: fix script

- add -s option to launch a single job per GPU
- add -v option to use tensorboard instead of wandb
- set nerfacto options according to https://github.com/nerfstudio-project/nerfstudio/issues/806#issuecomment-1284327844
- use a single timestamp for all training jobs
- last GPU was ignored
- kill all subprocesses when script is terminated
- print the eval script command-line

* launch_eval_blender.sh: fix script

* Update benchmarking.md

* launch_train_blender.sh: add -s to eval command-line

* Update launch_train_blender.sh

* Update benchmarking.md
2022-11-28 13:25:14 -08:00
cnsumnerandMatthew Tancik 3d70b4e614 Add support for insta360 single-file format (#1024)
* Add support for insta360 single-file format

* Improve some variable names

* Add documentation for crop_percentage parameter

Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2022-11-28 13:00:10 -08:00
Nicolas ZunhammerandNicolas Zunhammer bed7ef94c5 Add Docker support (#1022)
* Added Dockerfile to build docker image including all dependencies and nerfstudio, added description on how to user docker.

* Move docker description to Installation.md.

Co-authored-by: Nicolas Zunhammer <n.zunhammer@tum.de>
2022-11-28 12:58:59 -08:00
Matthew Tancik 0a57c7c72b Ignore non-image files in ns-process-data (#1040)
* Ignore non-image files in ns-process-data

* Update reqs

* bump ipython
2022-11-28 10:38:37 -08:00
David McAllister a578ac8d15 Camera Label Hiding (#1031)
* ThreeJS group traversal

* Isolated hiding to camera labels

* Logic for hide scene addeD
2022-11-27 22:46:10 -08:00
Matthew Tancik fff1fee686 Cleanup train cli logs (#1037) 2022-11-27 21:51:43 -08:00
David McAllister f739786d3a Pinched Looping Camera Path Fix (#1029)
Pinched looping path fix
2022-11-27 20:05:28 -08:00
Zak Murezandzmurez a7df91edc8 config nerfacto (#1020)
Co-authored-by: zmurez <zmurez@eng.ucsd.edu>
2022-11-27 15:56:06 -08:00
Alexander Kristoffersen aac7aa4786 Typo in ProcessRecord3D error (#1027)
small error fix.
2022-11-26 13:16:27 -08:00
Ethan Weber ee03a8f2c6 Switch colab pip install to git 2022-11-26 10:44:27 -08:00
Ethan Weber b23d76cc47 Cameras TensorDataclass and Phototourism (#961)
This branch gives us the flexibility to use Cameras as a tensordataclass, giving arbitrary batch dimensions, slicing, etc all for free. It tests this with the phototourism dataset.

Tensordataclass changes:
Originally, the tensordataclass would look at tensors in an object and take everything in front of the last dimension to be the batch dimensions, but in the case of the camera_to_world matrices, everything except for the last TWO are the important dimensions, so we needed to have a way for the tensordataclass to acknowledge these specific fields where there are multiple data dimensions behind the batch dimensions. This is important for things like reshaping where we need to know which dimensions get reshaped and which dimensions get left alone.

Cameras changes:
Now subclass of tensordataclass, which required a change to the tensordataclass itself.
The possibility of extra batch dimensions is the hairy part that requires the majority of these changes. The extra batch dimensions aren't a hassle in every function except in ray generation. The ray generation is where this operates different relative to the old cameras. The reason for this is before, for each ray we wanted to generate, we could specify a single index into our batch of cameras, but if you have multiple camera dimensions, for each ray, you need to now specify one index per camera batch dimension, meaning our camera_indices we specify need to have one extra dimension at the end, a dimension of size Cameras.ndim (number of batch dimensions in the camera object).
I also added some neat logic in generate_rays where if you want your output raybundle to be batched, if you specify batched camera_indices, you will receive the same batch size for the output raybundle, meaning you can easily generate raybundles corresponding to things like image patches and whatnot.

Phototourism changes:
The difficulty here is that images in the phototourism dataset are of different sizes, which is difficult because we can no longer batch the image tensors. We also need to better utilize caching in the CacheDataloader since the vanilladatamanager defaults don't really use it as well as they could, and without properly utilizing it, the rays / sec are maybe 25% of the standard nerfstudio dataset speeds (which are 10% of the size of the phototourism datasets). To do this, we specify a collate function in the existing datamanager configs, and we make a subclass of the vanilladatamanagerconfig named VariableResDataManagerConfig which will have a custom collate function storing the images in a list, and using better defaults for caching in the dataloader, caching ~40 images at a time. The slowest part of using a list is pixel sampling, where we added a custom if case for if our pixel sampler receives a batch of images that are in a list, and the lack of ability to vectorize operations over a list means that caching in the dataloader is even more important.
2022-11-25 22:16:11 -08:00
Jake Austin 1eae0839b4 Updating the script for downloading data (#968)
* Updating the script for downloading data

* Making update to config structure

* Updating documentation and colab

* Adding back the save directory

* Pushing an all flag for nerfstudio

* forgot to save some previous edits
2022-11-25 21:40:13 -08:00
Matthew Tancik 2c64ba5b6a Handle missing metashape data (#1015)
* Handle missing metashape data

* lint
2022-11-23 16:21:36 -08:00
Matthew Tancik 27ec772831 Improve webrtc stability (#1014)
debugging webrtc failed connections
2022-11-23 14:19:17 -08:00