4
0
mirror of https://github.com/nerfstudio-project/nerfstudio.git synced 2026-11-11 02:24:38 +08:00

Fix arguments that are not passed from config to NerfactoField (#2186)

* Fix arguments that are not passed from config to NerfactoField

* Add comments

* Reset base_res and features_per_level config of nerfacto-big and nerfacto-huge to default to match the original behavior

---------

Co-authored-by: Matthew Tancik <matt@lumalabs.ai>
This commit is contained in:
Yueh-Cheng Liu 劉岳承 2023-07-15 16:24:37 +02:00 committed by GitHub
parent 6329f53a5c
commit 8cd9beccd5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions

View File

@ -136,7 +136,6 @@ method_configs["nerfacto-big"] = TrainerConfig(
hidden_dim=128,
hidden_dim_color=128,
appearance_embed_dim=128,
base_res=32,
max_res=4096,
proposal_weights_anneal_max_num_iters=5000,
log2_hashmap_size=21,
@ -183,8 +182,6 @@ method_configs["nerfacto-huge"] = TrainerConfig(
hidden_dim=256,
hidden_dim_color=256,
appearance_embed_dim=32,
features_per_level=4,
base_res=32,
max_res=8192,
proposal_weights_anneal_max_num_iters=5000,
log2_hashmap_size=21,

View File

@ -50,10 +50,12 @@ class NerfactoField(Field):
hidden_dim: dimension of hidden layers
geo_feat_dim: output geo feat dimensions
num_levels: number of levels of the hashmap for the base mlp
base_res: base resolution of the hashmap for the base mlp
max_res: maximum resolution of the hashmap for the base mlp
log2_hashmap_size: size of the hashmap for the base mlp
num_layers_color: number of hidden layers for color network
num_layers_transient: number of hidden layers for transient network
features_per_level: number of features per level for the hashgrid
hidden_dim_color: dimension of hidden layers for color network
hidden_dim_transient: dimension of hidden layers for transient network
appearance_embedding_dim: dimension of appearance embedding

View File

@ -152,6 +152,8 @@ class NerfactoModel(Model):
hidden_dim=self.config.hidden_dim,
num_levels=self.config.num_levels,
max_res=self.config.max_res,
base_res=self.config.base_res,
features_per_level=self.config.features_per_level,
log2_hashmap_size=self.config.log2_hashmap_size,
hidden_dim_color=self.config.hidden_dim_color,
hidden_dim_transient=self.config.hidden_dim_transient,