From 8cd9beccd58a271bc7b071335590aa6eb9ff98df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yueh-Cheng=20Liu=20=E5=8A=89=E5=B2=B3=E6=89=BF?= Date: Sat, 15 Jul 2023 16:24:37 +0200 Subject: [PATCH] Fix arguments that are not passed from config to NerfactoField (#2186) * Fix arguments that are not passed from config to NerfactoField * Add comments * Reset base_res and features_per_level config of nerfacto-big and nerfacto-huge to default to match the original behavior --------- Co-authored-by: Matthew Tancik --- nerfstudio/configs/method_configs.py | 3 --- nerfstudio/fields/nerfacto_field.py | 2 ++ nerfstudio/models/nerfacto.py | 2 ++ 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/nerfstudio/configs/method_configs.py b/nerfstudio/configs/method_configs.py index b8ec7fede..428f91d01 100644 --- a/nerfstudio/configs/method_configs.py +++ b/nerfstudio/configs/method_configs.py @@ -136,7 +136,6 @@ method_configs["nerfacto-big"] = TrainerConfig( hidden_dim=128, hidden_dim_color=128, appearance_embed_dim=128, - base_res=32, max_res=4096, proposal_weights_anneal_max_num_iters=5000, log2_hashmap_size=21, @@ -183,8 +182,6 @@ method_configs["nerfacto-huge"] = TrainerConfig( hidden_dim=256, hidden_dim_color=256, appearance_embed_dim=32, - features_per_level=4, - base_res=32, max_res=8192, proposal_weights_anneal_max_num_iters=5000, log2_hashmap_size=21, diff --git a/nerfstudio/fields/nerfacto_field.py b/nerfstudio/fields/nerfacto_field.py index 3ba9efb82..34c6346fc 100644 --- a/nerfstudio/fields/nerfacto_field.py +++ b/nerfstudio/fields/nerfacto_field.py @@ -50,10 +50,12 @@ class NerfactoField(Field): hidden_dim: dimension of hidden layers geo_feat_dim: output geo feat dimensions num_levels: number of levels of the hashmap for the base mlp + base_res: base resolution of the hashmap for the base mlp max_res: maximum resolution of the hashmap for the base mlp log2_hashmap_size: size of the hashmap for the base mlp num_layers_color: number of hidden layers for color network num_layers_transient: number of hidden layers for transient network + features_per_level: number of features per level for the hashgrid hidden_dim_color: dimension of hidden layers for color network hidden_dim_transient: dimension of hidden layers for transient network appearance_embedding_dim: dimension of appearance embedding diff --git a/nerfstudio/models/nerfacto.py b/nerfstudio/models/nerfacto.py index 79e5b180e..3024c77cd 100644 --- a/nerfstudio/models/nerfacto.py +++ b/nerfstudio/models/nerfacto.py @@ -152,6 +152,8 @@ class NerfactoModel(Model): hidden_dim=self.config.hidden_dim, num_levels=self.config.num_levels, max_res=self.config.max_res, + base_res=self.config.base_res, + features_per_level=self.config.features_per_level, log2_hashmap_size=self.config.log2_hashmap_size, hidden_dim_color=self.config.hidden_dim_color, hidden_dim_transient=self.config.hidden_dim_transient,