Commit Graph
51 Commits
Author SHA1 Message Date
Matthew Tancik b1ddb9e695 Add split screen (#1898)
* Add split screen

* bug fixes
2023-05-10 10:55:17 -07:00
Matthew Tancik 82c0c5545b Fix misc warnings (#1894) 2023-05-09 14:11:28 -07:00
Matthew Tancik 28532c583f Render with colormaps (#1893)
* render with colormaps

* black
2023-05-09 12:26:44 -07:00
Jonáš Kulhánek 935e308c93 Fix viewer when opened before train setup finishes (#1888)
* Fix viewer when opened before train setup finishes

* is_initialized fix docs
2023-05-09 19:52:05 +02:00
Brent Yi 63c6303736 Bump minimum Python version to 3.8 (#1876)
* Bump minimum Python version to 3.8

* typing_extensions.Literal -> typing.Literal

* ns-dev-test

* typing_extensions.get_args => typing.get_args

* Format with older version of black

* Bump `black`

* Run black
2023-05-06 13:29:48 -07:00
Ethan Weber d847949fe9 fixing wandb envs (#1880)
* adding back support for wandb envs

* remove .init
2023-05-06 10:15:48 -07:00
Ethan Weber 081bf82bf5 Wandb/experiment improvements (#1879)
exposing experiment settings
2023-05-05 18:28:52 -07:00
Matthew Tancik 9ace02b3ae Remove nerfacc aabb (#1874)
* Remove nerfacc aabb

* remove custom nerfacc logic

* lint
2023-05-04 10:46:51 -07:00
Jonáš Kulhánek 231573bd8e Fix profiler for PyTorch 2.0 (#1812)
* Fix profiler for torch v2.0

* Add back type for time_function
2023-04-25 18:55:44 +02:00
Ruilong Li(李瑞龙) ea2993d5b1 Update NGP related models with nerfacc 0.5.2 (#1809)
* profiling

* set pose_optimizer to None if it's mode is "off"

* radial_and_tangential_undistort in nerfacc

* fix camera distortions

* update to nerfacc 0.5.1. Upgrade instant-ngp model.

* revert nerfacc to 0.5.1

* format

* allows to fall back to the pytorch undistortion

* format

* fix linting

* fix test

* fix test

* fix nerfplayer-ngp

* enable_collider=False for NGP

* nerfplayer verified.

* zero cone_angle for ngp bounded

* fix format

* fix pylint
2023-04-24 17:11:30 -07:00
Jonáš Kulhánek ea14152ae6 Add PyTorch profiler to support tracing of forward/backward calls (#1761)
* Add PyTorch profiler support

* Add support for wrapped code, fix linting errors

* Update docs
2023-04-18 20:29:09 +02:00
6a7c8820b8 Viewer backend refactor (#1702)
* Copy in `viser` communication infrastructure

* Update background image

* Add build directory to fix viser HTTP server
May want to remove these later

* Copy in `viser` communication infrastructure

* Update background image

* Pass dataset vis using viser

* initial impl of ViewerParameter

* idk what i did but brent and matt know

* Suppress eslint typescript warnings

* implement ViewerElement base class, then ViewerButton, ViewerSlider, etc

* client -> server message setup

* multi folder stuff

* Stream controls over viser

* import

* add types to viewer_param.py

* Move another message to viser

* Update folder color

* Use non throttled messages

* multiple folders works

* Cleanup, more porting

* starting impl of control panel in viser

* More porting

* scenebox to viser

* Cleanup

* Fix render updates

* More cleanup, docs, typing

* start control_panel.py

* set_hidden logic but not merged in

* control_panel replicates behavior of existing control panel (visually), except for setting the list of output options. not yet integrated with viewer_utils.py for logic flow. also implemented set_disabled and set_hidden in javscript/ViewerElement side

* Remove some original leva components

* add some train util logic, attempt set_value, doesn't work on javascript side fully yet (value updates but not slider visually

* bye zmq

* missing call to decoder

* 'gui_set' works properly, control panel now replicates behavior of original

* remove print

* Fix status viewer message

* More cleanup

* support set_options in dropdown

* hiding buttons works correctly

* fix set_options, switch from cur_value to get_value()

* Fix slowdown

* output options

* colormap logic converted

* add handle to cb_hook

* fix some lambda bugs

* cleanup

* Save checkpoint logic readded

* Cleanup and minor fixes

* snappier ui

* Refactoring

* Fix state update bugs

* Bug fixes

* Write less to redux

* added comments to reducer code

* Render state machine (#1727)

* state machine works, but train step throttling not implemented

* more step logic, cleanup

* remove random try catcH

* mutex logic for render

* Update lock logic

* types and docs

* added some state machine logic to help rerenders

* merge

---------

Co-authored-by: Justin <justin.g.kerr@gmail.com>

* Refactor and cleanup

* More cleanup and docs

* docstring to gui_utils

* docstrings, rename viewer_param.py to viewer_elements.py

* Fix viewer, remove bridge stuff

* Render on connect

* Fix lint errors

* More eslint fixes

* render_freq logic

* better rerender logic for crop

* More cleanup

* Purge

* Cleanup

* Lint fixes

* Fix cache

* better parsing logic

* Fix infinite test

* More cleanup

* typo

* Update webdocs

* Update docs

* rerender on custom hooks

* add more docs

* Use shared utilities in `viser.infra`

* rework callback to use elements instead of handles

* Fix ESlint errors

* change naming of handle to element, add setter for value

* cleanup

---------

Co-authored-by: Matt Tancik <mattt4001@gmail.com>
Co-authored-by: Justin <justin.g.kerr@gmail.com>
Co-authored-by: Ethan Weber <eweb0124@gmail.com>
Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-04-14 14:53:10 -07:00
Jonáš Kulhánek 6c8739ece2 Respect wandb environment variables (#1738) 2023-04-14 16:28:00 +02:00
Sacha LewinandMatthew Tancik 670d1e13d8 Use the run timestamp as run name on WandB (#1619)
Makes it way more convenient to run many experiments by splitting by experiment name, and then by timestamp.

Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-03-17 12:54:32 -07:00
Pablo Vela ddfa463f4d NeuS Implementation (#1444)
* add initial method configs and data manager

* add neus scheduler

* add initial surface model and neus

* add Neus ray sampler

* add sdf field

* move scale/shift calc to math utils

* add debug and fix sdf_dataset typo

* update vscode neus debug

* fix dataset and get initial working version

* add magic number from original repo

* black fixes

* clean up get weights/transmittance from alphas

* clean up typos in sdf datamanager

* type annotations on neus scheduler and remove unused params

* clean up and annotate sdf field along w/ other fixes

* more clean up

* remove unnessary directions norm

* resolve comments

* update neus scheduler to follow refactor

* fix linter errors

* fix some typos

* remove get_weights_from_alpha

* more comment fixes

* more linter error fixes

* clean up and add comments

* more little fixes for types/comments

* more comments

* rename NeuS Scheduler to DelayedScheduler

* rename DelayedScheduler to CosineDecayScheduler
2023-03-12 16:01:18 -04:00
Paul Wais 5c73766653 SFM: sfm-based depth, some breadcrumbs for pycolmap (#1457)
* save

* save

* more cleanup

* save

* save

* update phototourism

* save

* works

* works

* cleanup

* cleanup

* lint

* python3 default

* cleanup
2023-02-25 21:10:53 -08:00
Matthew Tancik 1916d9c85f Update ffmpeg comment (#1505)
update ffmpeg comment
2023-02-25 15:24:16 -08:00
Pablo Vela 6619dd1ac2 add monosdf normal loss and midas scale invariant depth loss (#1410)
* add monosdf normal loss and midas scale invariant depth loss

* add context to scale/shift calc and normal loss, consolidate MidasMSE loss

* consolidated, add info on gradient reg term

* add info on ssi

* more documentation and type annotation

* move compute scale/shift to class

* fix pylint errors

* fix tensortype error

* fix comments

* change single var name and update comment

* fix input tensortype

* fix black error

* fix mask shape
2023-02-15 13:49:35 -06:00
NCJ 92cadf5ce4 Fix Multiple Typos (#1376)
fix multiple typos
2023-02-08 10:33:23 -08:00
Matthew Tancik ef9e00e614 Check if curl is installed (#1337)
* check if curl is installed

* lint
2023-02-02 10:11:41 -08:00
Matthew Tancik 53a830a691 Safe normalize (#1332) 2023-02-01 13:22:32 -08:00
Matthew Tancik 567268854b Cleanup aabb intersection logic (#1329) 2023-02-01 12:18:09 -08:00
Mason McGough 3b8e2ce9ec Add step argument in eval_utils.py to fix rendering bug. (#1272) 2023-01-20 16:11:10 -08:00
2120bd5dd9 CropBox GUI implementation (#1205)
* fixed an exception bug in case of num_samples is 0

fixed an exception bug when num samples is 0 , 
"IndexError tensors used as indices must be long, byte or bool tensors"

change type to long ( was float32)

* implemented crop box in gui. For now works on instant-ngp-bounded

* fixed import bugs

* update aabb every time and not only on training

* prevent crash when chosing accomulation and crop box

* Checkbox

* max_box is bounded by scevne box in the gui

* implemented altenative intesection to nerfacc

* convert str to bool correctly

* fixed isort bug

* fixed isort bug2

* update viewer version

* remove json bug

* Update UI

* Force black background

* Fix formatting

Co-authored-by: dror <you@example.com>
Co-authored-by: Matt Tancik <tancik@berkeley.edu>
Co-authored-by: Matthew Tancik <mattt4001@gmail.com>
2023-01-19 17:39:37 -08:00
matsurenandMatthew Tancik 408ab709ec Fix typo (#1231)
* Fix typo COLAMP->COLMAP

* Fix more typo

Co-authored-by: Matthew Tancik <tancik@berkeley.edu>
2023-01-16 12:12:55 -08:00
86d8118b6d fix notebook, box drawing (#1202)
* fix notebook

* samples

* run all cells

* box center

* try saving again

* import order

* cube with different sides

* black

* black

* update metadata

* fix test

Co-authored-by: Katrin Schmid <kabischmid@gmail.com>
Co-authored-by: Matt Tancik <tancik@berkeley.edu>
2023-01-06 20:22:55 -08:00
Jake Austin 3ffee522e0 TrainerConfig inherit from InstantiateConfig (#1175)
Making TrainerConfig an InstantiateConfig so it can be swapped in and out with different methods. Also made the TrainerConfig a subclass of ExperimentConfig (which was changed from a printableconfig to an instantiateconfig), since we were already instantiating the Trainer class with the ExperimentConfig

Removed the "config" field from the TrainerCallbackAttributes struct to eliminate circular dependencies when types are checked.

Minor scripts and docs changes to accommodate the update to the config struct, meaning the flags that were associated with the TrainerConfig were moved up to the top level of the config.
2022-12-27 18:19:34 -10:00
Matthew Tancik 21e0ec6cd8 Log start iter (#1119)
log start iter
2022-12-13 12:50:12 -08:00
Nikhil Mohan 98f13cbed4 Fix circular imports (#1115)
* wip

* remove bad changes

* update dmeo

* cleanup

* change name

* cleanup
2022-12-13 10:09:31 -08:00
Ethan WeberandMatt Tancik 1052fccec2 Mesh export (#809)
* start of mesh PR

* point cloud export mvp

* start of mesh PR

* point cloud export mvp

* Save out mesh. Poor quality atm

* reorganized mesh algorithms and specified CLI

* CLI reorg

* tsdf algorithm in progress

* debugging

* tsdf functional but camera distortion params not in

* playing with distortion params

* TSDF works but texture looks bad

* added trimesh

* moved to exporter

* removed files

* saving progress

* save texture image

* seems to work w/o barycentric

* barycentric start

* gap between triangles

* blocking out diagonal

* new barcentric and scaling

* meshing working. need to remove extra rows

* fixed triangle packing

* gitignore changes

* removed package

* fix Literal import

* comments

* update .mtl file

* poisson mesh with model output normals & resolved some PR comments on git

* starting docs. breaking up big function. todo: add xatlas

* xatlas and nvdiffrast working

* triangle_id

* progress on expensive texture coordinates method

* pytorch meshing works

* removing nvdiffrast

* remove trimesh

* cleanup

* few changes

* pred normals by default and add minimum additions to viewer

* fix cli in viewer

* add xatlas as dependency

* make point cloud more dense

* reverted viewer changes

* turn off normals by default

* fix docs

* finished todos on github

* remove xatlas

* xatlas

* black

Co-authored-by: Matt Tancik <tancik@berkeley.edu>
2022-12-02 10:49:19 -08:00
Kevin Chen 5adbef8cf6 Fix torch spherical harmonics (#1054) 2022-11-29 20:35:35 -08:00
Matthew Tancik fff1fee686 Cleanup train cli logs (#1037) 2022-11-27 21:51:43 -08:00
Ethan Weber b23d76cc47 Cameras TensorDataclass and Phototourism (#961)
This branch gives us the flexibility to use Cameras as a tensordataclass, giving arbitrary batch dimensions, slicing, etc all for free. It tests this with the phototourism dataset.

Tensordataclass changes:
Originally, the tensordataclass would look at tensors in an object and take everything in front of the last dimension to be the batch dimensions, but in the case of the camera_to_world matrices, everything except for the last TWO are the important dimensions, so we needed to have a way for the tensordataclass to acknowledge these specific fields where there are multiple data dimensions behind the batch dimensions. This is important for things like reshaping where we need to know which dimensions get reshaped and which dimensions get left alone.

Cameras changes:
Now subclass of tensordataclass, which required a change to the tensordataclass itself.
The possibility of extra batch dimensions is the hairy part that requires the majority of these changes. The extra batch dimensions aren't a hassle in every function except in ray generation. The ray generation is where this operates different relative to the old cameras. The reason for this is before, for each ray we wanted to generate, we could specify a single index into our batch of cameras, but if you have multiple camera dimensions, for each ray, you need to now specify one index per camera batch dimension, meaning our camera_indices we specify need to have one extra dimension at the end, a dimension of size Cameras.ndim (number of batch dimensions in the camera object).
I also added some neat logic in generate_rays where if you want your output raybundle to be batched, if you specify batched camera_indices, you will receive the same batch size for the output raybundle, meaning you can easily generate raybundles corresponding to things like image patches and whatnot.

Phototourism changes:
The difficulty here is that images in the phototourism dataset are of different sizes, which is difficult because we can no longer batch the image tensors. We also need to better utilize caching in the CacheDataloader since the vanilladatamanager defaults don't really use it as well as they could, and without properly utilizing it, the rays / sec are maybe 25% of the standard nerfstudio dataset speeds (which are 10% of the size of the phototourism datasets). To do this, we specify a collate function in the existing datamanager configs, and we make a subclass of the vanilladatamanagerconfig named VariableResDataManagerConfig which will have a custom collate function storing the images in a list, and using better defaults for caching in the dataloader, caching ~40 images at a time. The slowest part of using a list is pixel sampling, where we added a custom if case for if our pixel sampler receives a batch of images that are in a list, and the lack of ability to vectorize operations over a list means that caching in the dataloader is even more important.
2022-11-25 22:16:11 -08:00
Matthew Tancik 532f8067fd Refactor process data (#976) 2022-11-18 09:19:44 -08:00
Matthew Tancik 6baf31dc9a Fix python 3.7 support (#959) 2022-11-15 09:51:23 -08:00
Nikhil Mohan b5c34f0154 Add 'inference' mode to pipeline (#956)
* cleanup test mode

* cleanup eval loading

* change default

* cleanup

* cleanup

* comment
2022-11-14 16:56:36 +00:00
Ethan Weber 6f4fb506e2 Multi-gpu improvements (#799)
* initial commit

* minor changes

* small changes

* ddp seems to be working

* remove commented out code
2022-10-20 01:11:40 -07:00
Ethan WeberandEthan Weber d71c05f256 Google Colab support with viewer (#747)
* allows bridge server to run on a different machine

* added script

* update version

* starting docs

* update docs and scripts

* ngrok support

* use tcp

* moving webrtc outside bridge server. wop

* lazy commit

* lazy commit

* running code. webrtc not working

* lazy commit

* better logic for webrtc connection

* cleanup

* todo comment

* working webrtc

* removed logging

* fixing black

* fix eslint

* fix python version

* fix readme

* misc cleanup

* small docs fix

Co-authored-by: Ethan Weber <ethanweber@Ethans-MacBook-Pro.local>
2022-10-14 15:05:28 -07:00
2150bad0e4 Reducing flicker artifacts for nerfacto method (#750)
* pose opt default nerfacto.

* added SO3 cam pose optimization which is slightly faster (~2.2m/iter) than BARF

* added occupancy grid with placeholder until nerfacc is updated to query density from it

* added occupancy grid sampling as the level 0 in proposal hierarchy, relies on nerfacc 0.1.7 (on pypi)

* merge main

* merge main

* minor changes to sampling

* adjusted sample number

* refactor occ grid stuff, settle on decent params

* nograd proposal sampling

* param tweaks

* varying resolution proposal networks

* params

* merged main

* optimizer update

* remove occ grid

* remove double nerfacto samples

* set single jitter to true

* remove pdb

* more changes

* fix method defaults

* fix pylint

* remove occupancy fn

Co-authored-by: akristoffersen <akristoffersen@berkeley.edu>
Co-authored-by: Justin Kerr <justin.g.kerr@gmail.com>
2022-10-11 14:21:00 -07:00
Matthew Tancik 9252a46273 Check ffmpeg before rendering video (#715)
* check ffmpeg before rendering video

* Fix imports
2022-10-06 09:41:36 -07:00
Ethan Weber b8f85fb603 doubling nerfacto samples on eval (#675)
doubling samples and eval num ray options
2022-10-04 22:57:24 -07:00
evonneng 5c3e1e8bb7 split scripts into 2 eval/render (#637)
* done splitting script

* udpate docs

* woops forgot to add function

* update camera panel command
2022-10-03 22:08:21 -07:00
evonneng 968959bdc9 quickstart updates + (other nits+links added to repo) (#633)
* small changes

* rewrite quickstart + readme

* fixed all licensing headers

* nits
2022-10-03 16:01:16 -07:00
Ethan Weber c20fed83bb moving around files (#616)
moved around files
2022-10-02 16:54:34 -07:00
evonneng 50d9aa1341 small fixes (#581)
* small fix

* oom error

* created model wrapper; make DDP working again; todo need to check if it works with viewer

* working with multigpu now
2022-10-02 13:54:13 -07:00
Matthew Tancik afda888591 tcnn encoding integration (#608)
* tcnn encoding integration

* Add tests, fix lint

* lin
2022-10-02 10:33:43 -07:00
Jake Austin bc2aa64aba Cameras (#504)
Cameras now support being batched down the line without changing types of camera attributes
2022-10-01 20:26:12 -07:00
Ethan Weber e13d401b16 restructure codebase pre release (#602)
* moving a lot

* building
2022-10-01 16:36:25 -07:00
Ethan Weber 3e61e315bb updated download script (#592)
* updated download script

* rename

* remove omegaconf
2022-09-30 11:29:57 -07:00
Matthew Tancik 5fac867502 Misc viewer cleanup (#591)
* Misc viewer cleanup

* fix lint
2022-09-30 10:32:44 -07:00