From f299098f4680dee323e26ff66eb6e9d78c3f4226 Mon Sep 17 00:00:00 2001 From: Matthew Tancik Date: Mon, 8 May 2023 11:48:28 -0700 Subject: [PATCH] Fix viewer quit-on-train-completion (#1885) --- nerfstudio/engine/trainer.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/nerfstudio/engine/trainer.py b/nerfstudio/engine/trainer.py index 1c3ed3ad2..79fb72261 100644 --- a/nerfstudio/engine/trainer.py +++ b/nerfstudio/engine/trainer.py @@ -299,7 +299,8 @@ class Trainer: table.add_row("Checkpoint Directory", str(self.checkpoint_dir)) CONSOLE.print(Panel(table, title="[bold][green]:tada: Training Finished :tada:[/bold]", expand=False)) - self._train_complete_viewer() + if not self.config.viewer.quit_on_train_completion: + self._train_complete_viewer() @check_main_thread def _check_viewer_warnings(self) -> None: @@ -344,8 +345,7 @@ class Trainer: def _train_complete_viewer(self) -> None: """Let the viewer know that the training is complete""" assert self.viewer_state is not None - if not self.config.viewer.quit_on_train_completion: - self.training_state = "completed" + self.training_state = "completed" try: self.viewer_state.training_complete() except RuntimeError: