From db752122548cb371e8d65da89a9964b830cc3fef Mon Sep 17 00:00:00 2001 From: ethanweber Date: Tue, 13 Sep 2022 18:34:23 +0000 Subject: [PATCH] Prettified Code! --- .../viewer/app/src/modules/SidePanel/CameraPanel/curve.js | 1 - .../viewer/app/src/modules/ViewerWindow/ViewerWindow.jsx | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/nerfactory/viewer/app/src/modules/SidePanel/CameraPanel/curve.js b/nerfactory/viewer/app/src/modules/SidePanel/CameraPanel/curve.js index ccc53c707..55535f5d5 100644 --- a/nerfactory/viewer/app/src/modules/SidePanel/CameraPanel/curve.js +++ b/nerfactory/viewer/app/src/modules/SidePanel/CameraPanel/curve.js @@ -2,7 +2,6 @@ import * as THREE from 'three'; - function get_curve(list_of_3d_vectors) { // TODO: add some hyperparameters to this function const curve = new THREE.CatmullRomCurve3( diff --git a/nerfactory/viewer/app/src/modules/ViewerWindow/ViewerWindow.jsx b/nerfactory/viewer/app/src/modules/ViewerWindow/ViewerWindow.jsx index b929571e7..a4a57625a 100644 --- a/nerfactory/viewer/app/src/modules/ViewerWindow/ViewerWindow.jsx +++ b/nerfactory/viewer/app/src/modules/ViewerWindow/ViewerWindow.jsx @@ -262,9 +262,9 @@ export default function ViewerWindow(props) { // set the threejs field of view // such that the rendered video will match correctly if (camera_choice !== 'Main Camera') { - const fl = 1.0 / Math.tan(field_of_view * Math.PI / 360); + const fl = 1.0 / Math.tan((field_of_view * Math.PI) / 360); const fl_new = fl * render_viewport_apsect_ratio; - const fov = Math.atan(1/fl_new) / (Math.PI / 360); + const fov = Math.atan(1 / fl_new) / (Math.PI / 360); sceneTree.metadata.camera.fov = fov; }