From c7911281c3a9f8bfae3c9c82744ddf7390fdc568 Mon Sep 17 00:00:00 2001
From: evonneng <evonne_ng@berkeley.edu>
Date: Sat, 9 Apr 2022 05:26:22 +0000
Subject: [PATCH] fixing documentation for unfinished module ordering function

---
 mattport/nerf/graph.py | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/mattport/nerf/graph.py b/mattport/nerf/graph.py
index 843cde7c2..84b8997ee 100644
--- a/mattport/nerf/graph.py
+++ b/mattport/nerf/graph.py
@@ -15,11 +15,7 @@ class GraphInputs:
 
 
 class Graph(nn.Module):
-    """_summary_
-
-    Args:
-        nn (_type_): _description_
-    """
+    """_summary_ """
 
     def __init__(self, modules_config: dict) -> None:
         super().__init__()
@@ -34,17 +30,16 @@ class Graph(nn.Module):
                 module_dict["meta_data"]["in_dim"] = in_dim
             self.modules[module_name] = module(**module_dict["meta_data"])
 
-    def get_module_order(self, modules_config: list):
-        """Generates a graph to determine the order in which the graph should execute
+    def get_module_order(self, modules_config: dict) -> list:
+        """Generates a graph to determine the order in which the modules should execute
 
         Args:
-            modules_config (list): _description_
+            modules_config (dict): module definitions that make up the network
 
         Returns:
-            _type_: _description_
+            list: ordering of the module names that should be executed
         """
-        # raise NotImplementedError
-        return modules_config
+        raise NotImplementedError
 
     def forward(self, x):
         """_summary_
@@ -52,6 +47,6 @@ class Graph(nn.Module):
         Args:
             x (_type_): _description_
         """
-        # raise NotImplementedError
-        for name in self.module_order:
-            x = self.modules[name](x)
+        # for name in self.module_order:
+        #     x = self.modules[name](x)
+        raise NotImplementedError