From c2b5671018bb32ee35991a57b40d0c4ec0a430cb Mon Sep 17 00:00:00 2001 From: Matthew Tancik Date: Tue, 27 Sep 2022 18:49:02 -0700 Subject: [PATCH] Fix non stratified PDF sampling (#571) --- nerfactory/models/modules/ray_sampler.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nerfactory/models/modules/ray_sampler.py b/nerfactory/models/modules/ray_sampler.py index 29a717e4b..603f2e57c 100644 --- a/nerfactory/models/modules/ray_sampler.py +++ b/nerfactory/models/modules/ray_sampler.py @@ -349,7 +349,8 @@ class PDFSampler(Sampler): u = u + torch.rand(size=(*cdf.shape[:-1], num_bins), device=cdf.device) / num_bins else: # Uniform samples between 0 and 1 - u = torch.linspace(0.0, 1.0, steps=num_bins, device=cdf.device) + u = torch.linspace(0.0, 1.0 - (1.0 / num_bins), steps=num_bins, device=cdf.device) + u = u + 1.0 / (2 * num_bins) u = u.expand(size=(*cdf.shape[:-1], num_bins)) u = u.contiguous()