diff --git a/nerfactory/configs/base.py b/nerfactory/configs/base.py index 3db6903e8..b5680d8ed 100644 --- a/nerfactory/configs/base.py +++ b/nerfactory/configs/base.py @@ -347,7 +347,7 @@ class ViewerConfig(PrintableConfig): relative_log_filename: str = "viewer_log_filename.txt" """Filename to use for the log file.""" log_filename: dcargs.conf.Fixed[Path] = dcargs.MISSING - """Absolute path to the log file. Set automatically.""" + """[Do not set] Absolute path to the log file. Set automatically.""" start_train: bool = True """whether to immediately start training upon loading viewer if False, will just visualize dataset but you can toggle training in viewer""" diff --git a/nerfactory/configs/base_configs.py b/nerfactory/configs/base_configs.py index f7236e301..2953883fe 100644 --- a/nerfactory/configs/base_configs.py +++ b/nerfactory/configs/base_configs.py @@ -46,8 +46,8 @@ from nerfactory.models.semantic_nerf import SemanticNerfModel from nerfactory.models.vanilla_nerf import NeRFModel base_configs: Dict[str, Config] = {} -base_configs["instant_ngp"] = Config( - method_name="instant_ngp", +base_configs["instant-ngp"] = Config( + method_name="instant-ngp", trainer=TrainerConfig(steps_per_eval_batch=500, steps_per_save=2000, mixed_precision=True), pipeline=PipelineConfig( datamanager=VanillaDataManagerConfig(train_dataparser=BlenderDataParserConfig(), train_num_rays_per_batch=8192), @@ -63,9 +63,9 @@ base_configs["instant_ngp"] = Config( logging=LoggingConfig(event_writer="none"), ) -base_configs["mipnerf_360"] = Config( - experiment_name="mipnerf_360", - method_name="mipnerf_360", +base_configs["mipnerf-360"] = Config( + experiment_name="mipnerf-360", + method_name="mipnerf-360", trainer=TrainerConfig(steps_per_eval_batch=200), pipeline=PipelineConfig( datamanager=VanillaDataManagerConfig( @@ -107,9 +107,9 @@ base_configs["nerfw"] = Config( ), ) -base_configs["semantic_nerf"] = Config( +base_configs["semantic-nerf"] = Config( experiment_name="friends_TBBT-big_living_room", - method_name="semantic_nerf", + method_name="semantic-nerf", pipeline=PipelineConfig( datamanager=VanillaDataManagerConfig( train_dataparser=FriendsDataParserConfig(), @@ -123,8 +123,8 @@ base_configs["semantic_nerf"] = Config( ), ) -base_configs["vanilla_nerf"] = Config( - method_name="vanilla_nerf", +base_configs["vanilla-nerf"] = Config( + method_name="vanilla-nerf", pipeline=PipelineConfig( datamanager=VanillaDataManagerConfig( train_dataparser=BlenderDataParserConfig(), diff --git a/tests/test_run_train.py b/tests/test_run_train.py index 95c947cf6..7753ccc9b 100644 --- a/tests/test_run_train.py +++ b/tests/test_run_train.py @@ -13,7 +13,7 @@ import nerfactory.configs.base as cfg from nerfactory.configs.base_configs import base_configs from nerfactory.engine.trainer import train_loop -BLACKLIST = ["base", "semantic_nerf", "mipnerf_360", "instant_ngp", "compound"] +BLACKLIST = ["base", "semantic-nerf", "mipnerf-360", "instant-ngp", "compound"] def set_reduced_config(config: cfg.Config): @@ -41,7 +41,7 @@ def set_reduced_config(config: cfg.Config): config.viewer.enable = False # model specific config settings - if config.method_name == "instant_ngp": + if config.method_name == "instant-ngp": config.pipeline.model.field_implementation = "torch" config.populate_dynamic_fields()