From b03755d6abda52cf177b3ab75a69aa424617aeed Mon Sep 17 00:00:00 2001 From: evonneng Date: Fri, 12 Aug 2022 09:53:29 -0700 Subject: [PATCH] [WIP] added preset button controls; moved rendering into timing loop (#270) added preset button controls; moved rendering into timing loop --- nerfactory/engine/trainer.py | 1 - .../viewer/app/src/modules/ConfigPanel/ConfigPanel.jsx | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/nerfactory/engine/trainer.py b/nerfactory/engine/trainer.py index 83b3d6fee..181351f42 100644 --- a/nerfactory/engine/trainer.py +++ b/nerfactory/engine/trainer.py @@ -105,7 +105,6 @@ class Trainer: # Note: if visualizer used, the rendering of the visualizer will be included in the iteration train time with TimeWriter(writer, EventName.ITER_TRAIN_TIME, step=step) as t: loss_metric_dict = self.train_iteration(step) - with TimeWriter(writer, EventName.ITER_VIS_TIME, step=step) as t: self.visualizer_state.update_scene(step, self.pipeline.model) diff --git a/nerfactory/viewer/app/src/modules/ConfigPanel/ConfigPanel.jsx b/nerfactory/viewer/app/src/modules/ConfigPanel/ConfigPanel.jsx index 7e3f15e08..360c308f2 100644 --- a/nerfactory/viewer/app/src/modules/ConfigPanel/ConfigPanel.jsx +++ b/nerfactory/viewer/app/src/modules/ConfigPanel/ConfigPanel.jsx @@ -213,6 +213,12 @@ export function RenderControls() { set_fov(v); }, }, + // training speed + "Train Speed": buttonGroup({ + 'Fast': () => setControls({ min_resolution: 10, max_resolution: 10 }), + 'Balanced': () => setControls({min_resolution: 50, max_resolution: 512 }), + 'Slow': () => setControls({ min_resolution: 100, max_resolution: 1024 }), + }), }), [ isTraining,