From 9b0cf2ab16847ca3e351ed52ec7d3f51fc6053f4 Mon Sep 17 00:00:00 2001 From: Terrance Wang Date: Thu, 1 Sep 2022 12:11:28 -0700 Subject: [PATCH] Terrance/instant ngp bug (#324) * adding after iter callbacks in training loop * moved callback * fixed network name Co-authored-by: Ethan Weber --- nerfactory/engine/trainer.py | 5 +++++ nerfactory/models/vanilla_nerf.py | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/nerfactory/engine/trainer.py b/nerfactory/engine/trainer.py index ff9c496f8..bd5216c5d 100644 --- a/nerfactory/engine/trainer.py +++ b/nerfactory/engine/trainer.py @@ -138,6 +138,11 @@ class Trainer: ) loss_metric_dict = self.train_iteration(step) + + # training callbacks after the training iteration + for callback in self.callbacks: + callback.run_callback_at_location(step, location=TrainingCallbackLocation.AFTER_TRAIN_ITERATION) + with TimeWriter(writer, EventName.ITER_VIS_TIME, step=step) as _: self.visualizer_state.update_scene(step, self.pipeline.model) diff --git a/nerfactory/models/vanilla_nerf.py b/nerfactory/models/vanilla_nerf.py index 70ba6ce46..0f5dd1548 100644 --- a/nerfactory/models/vanilla_nerf.py +++ b/nerfactory/models/vanilla_nerf.py @@ -85,7 +85,7 @@ class NeRFModel(Model): where_to_run=[TrainingCallbackLocation.AFTER_TRAIN_ITERATION], update_every_num_iters=self.density_field.update_every_num_iters, func=self.density_field.update_density_grid, - kwargs={"density_eval_func": self.field.density_fn}, # type: ignore + kwargs={"density_eval_func": self.field_coarse.density_fn}, # type: ignore ) ] return callbacks