From 98e6b30e2986ea77844ccabf8c59d42cfe1099cb Mon Sep 17 00:00:00 2001
From: wyyyz1937365497 <wyyyz1937365497@users.noreply.github.com>
Date: Sat, 1 Aug 2026 14:11:45 +0800
Subject: [PATCH] fix(process_data): handle numpy array in
 write_points3D_binary error field
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`read_points3D_binary` stores `error` as a numpy array, but
`write_points3D_binary` passed it directly to `struct.pack("<d", ...)`,
which fails on numpy 2.x because 1-d arrays are no longer auto-coerced
to Python scalars.  Wrap `pt.error.item()` in `float()` for robust
extraction—this matches the existing convention in
`write_cameras_binary` (line 184: `float(p)`).

Fixes a pre-existing test failure on CI where
`test_process_images_skip_colmap` and
`test_process_images_recursively_skip_colmap` crashed with
`struct.error: required argument is not a float`.
---
 nerfstudio/data/utils/colmap_parsing_utils.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nerfstudio/data/utils/colmap_parsing_utils.py b/nerfstudio/data/utils/colmap_parsing_utils.py
index 0eeaf6911..c5afd5689 100644
--- a/nerfstudio/data/utils/colmap_parsing_utils.py
+++ b/nerfstudio/data/utils/colmap_parsing_utils.py
@@ -399,7 +399,7 @@ def write_points3D_binary(points3D, path_to_model_file):
             write_next_bytes(fid, pt.id, "Q")
             write_next_bytes(fid, pt.xyz.tolist(), "ddd")
             write_next_bytes(fid, pt.rgb.tolist(), "BBB")
-            write_next_bytes(fid, pt.error, "d")
+            write_next_bytes(fid, float(pt.error.item()), "d")
             track_length = pt.image_ids.shape[0]
             write_next_bytes(fid, track_length, "Q")
             for image_id, point2D_id in zip(pt.image_ids, pt.point2D_idxs):