From 8f9443f84e094ee57e55984daf6c4cf0f37014b6 Mon Sep 17 00:00:00 2001 From: Afloat Date: Mon, 9 Nov 2026 10:07:18 +0800 Subject: [PATCH] Cover normalized ODM offsets in a portrait calibration Use a 600 x 800 input to exercise the height as the normalization scale. The expected horizontal principal point is 379.5 pixels, while main 50e0e3c returns 299.6. All five fixtures fail on main and pass with the patch using the real importer. Ruff 0.12.2 lint and format checks pass. The earlier CI run reports the same 19 Pyright diagnostic locations and messages as PR #3797 at the same base. Both Docker runs stop building tiny-cuda-nn because pkg_resources is unavailable. https://github.com/nerfstudio-project/nerfstudio/actions/runs/42401285154 https://github.com/nerfstudio-project/nerfstudio/actions/runs/37900213951 https://github.com/nerfstudio-project/nerfstudio/actions/runs/42401284860 https://github.com/nerfstudio-project/nerfstudio/actions/runs/37900214031 --- tests/process_data/test_odm_utils.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/process_data/test_odm_utils.py b/tests/process_data/test_odm_utils.py index f770f40ff..41b51bc60 100644 --- a/tests/process_data/test_odm_utils.py +++ b/tests/process_data/test_odm_utils.py @@ -13,6 +13,10 @@ from nerfstudio.process_data.odm_utils import cameras2nerfds [ ({"projection_type": "perspective", "focal": 0.5}, {"fl_x": 400, "cx": 399.5, "cy": 299.5}), ({"projection_type": "brown", "focal": 0.5, "c_x": 0.1, "c_y": -0.05}, {"cx": 479.5, "cy": 259.5}), + ( + {"projection_type": "brown", "width": 600, "height": 800, "focal": 0.5, "c_x": 0.1, "c_y": -0.05}, + {"fl_x": 400, "fl_y": 400, "cx": 379.5, "cy": 359.5}, + ), ({"projection_type": "fisheye_opencv", "focal": 0.5, "k4": 0.004}, {"k4": 0.004}), ({"projection_type": "spherical"}, {"fl_x": 400, "fl_y": 600, "cx": 400, "cy": 300}), ],