From 8f4f89cf87454419bfc67a390c931f4e7718227e Mon Sep 17 00:00:00 2001 From: Matthew Tancik Date: Thu, 18 May 2023 16:03:25 -0700 Subject: [PATCH] Don't run temporal tv loss test (#1952) --- tests/field_components/test_temporal_grid.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/field_components/test_temporal_grid.py b/tests/field_components/test_temporal_grid.py index 137f4fc2d..977b6a419 100644 --- a/tests/field_components/test_temporal_grid.py +++ b/tests/field_components/test_temporal_grid.py @@ -38,7 +38,9 @@ def test_temporal_grid(): assert model.embeddings.grad.sum() - weight.sum() < 0.01 assert torch.all(model.embeddings.grad[2:, :] == 0) assert torch.all(model.embeddings.grad[:, 1:] == 0) - model.get_temporal_tv_loss() + # TODO: test temporal_tv_loss + # model.get_temporal_tv_loss() + # TODO: Any better way to numerically test it? Especially for the gradients. # (maybe add some randomness and multiple cases for the testing?)