From 81fbee213fd592983debef9a9b21c9964d162648 Mon Sep 17 00:00:00 2001 From: evonneng Date: Tue, 6 Sep 2022 16:04:43 -0700 Subject: [PATCH] removed load; iter_train_time includes load time (#351) --- docs/tooling/logging_profiling.md | 4 ++-- nerfactory/configs/base.py | 1 - nerfactory/utils/writer.py | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/tooling/logging_profiling.md b/docs/tooling/logging_profiling.md index b6de17a68..6b6ff77e8 100644 --- a/docs/tooling/logging_profiling.md +++ b/docs/tooling/logging_profiling.md @@ -18,7 +18,7 @@ logging: LocalWriter: log_dir: "./" stats_to_track: - [ITER_LOAD_TIME, ITER_TRAIN_TIME, RAYS_PER_SEC, CURR_TEST_PSNR] + [ITER_TRAIN_TIME, RAYS_PER_SEC, CURR_TEST_PSNR] max_log_size: 10 ``` @@ -46,7 +46,7 @@ WandbWriter: LocalWriter: log_dir: "./" # if images are saved, where the images would be saved stats_to_track: - [ITER_LOAD_TIME, ITER_TRAIN_TIME, RAYS_PER_SEC, CURR_TEST_PSNR] + [ITER_TRAIN_TIME, RAYS_PER_SEC, CURR_TEST_PSNR] max_log_size: 10 ``` diff --git a/nerfactory/configs/base.py b/nerfactory/configs/base.py index 93677be81..0616036d7 100644 --- a/nerfactory/configs/base.py +++ b/nerfactory/configs/base.py @@ -114,7 +114,6 @@ class LocalWriterConfig(InstantiateConfig): _target: Type = writer.LocalWriter enable: bool = False stats_to_track: Tuple[writer.EventName, ...] = ( - writer.EventName.ITER_LOAD_TIME, writer.EventName.ITER_TRAIN_TIME, writer.EventName.RAYS_PER_SEC, writer.EventName.CURR_TEST_PSNR, diff --git a/nerfactory/utils/writer.py b/nerfactory/utils/writer.py index 98b704c2a..4b568ac76 100644 --- a/nerfactory/utils/writer.py +++ b/nerfactory/utils/writer.py @@ -45,7 +45,6 @@ class EventName(enum.Enum): """Names of possible events that can be logged via Local Writer for convenience. see config/logging/default_logging.yaml""" - ITER_LOAD_TIME = "Data Load (time)" ITER_TRAIN_TIME = "Train Iter (time)" TOTAL_TRAIN_TIME = "Train Total (time)" ITER_VIS_TIME = "Visualizer Rendering (time)"