From 7537551f385a0ad6aeed45795866db561312da7e Mon Sep 17 00:00:00 2001 From: Ethan Weber Date: Sat, 6 May 2023 12:19:26 -0700 Subject: [PATCH] Avoids running test_train.py on external methods (#1882) removes testing on external methods --- nerfstudio/configs/method_configs.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/nerfstudio/configs/method_configs.py b/nerfstudio/configs/method_configs.py index 3390a1bfa..f9af96427 100644 --- a/nerfstudio/configs/method_configs.py +++ b/nerfstudio/configs/method_configs.py @@ -83,6 +83,7 @@ descriptions = { "nerfplayer-nerfacto": "NeRFPlayer with nerfacto backbone.", "nerfplayer-ngp": "NeRFPlayer with InstantNGP backbone.", "neus": "Implementation of NeuS. (slow)", + "neus-facto": "Implementation of NeuS-Facto. (slow)", } method_configs["nerfacto"] = TrainerConfig( @@ -589,12 +590,12 @@ method_configs["neus-facto"] = TrainerConfig( ) external_methods, external_descriptions = discover_methods() -method_configs.update(external_methods) -descriptions.update(external_descriptions) +all_methods = {**method_configs, **external_methods} +all_descriptions = {**descriptions, **external_descriptions} AnnotatedBaseConfigUnion = tyro.conf.SuppressFixed[ # Don't show unparseable (fixed) arguments in helptext. tyro.conf.FlagConversionOff[ - tyro.extras.subcommand_type_from_defaults(defaults=method_configs, descriptions=descriptions) + tyro.extras.subcommand_type_from_defaults(defaults=all_methods, descriptions=all_descriptions) ] ] """Union[] type over config types, annotated with default instances for use with