From 5a096a6f4c08688aecd66bcc31bd7850353a4cc6 Mon Sep 17 00:00:00 2001 From: Jake Austin Date: Sat, 7 Jan 2023 10:06:52 +0000 Subject: [PATCH] Transmittance loss bug fix --- nerfstudio/models/dreamfusion.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/nerfstudio/models/dreamfusion.py b/nerfstudio/models/dreamfusion.py index e5f7cd341..78bf96f43 100644 --- a/nerfstudio/models/dreamfusion.py +++ b/nerfstudio/models/dreamfusion.py @@ -131,9 +131,10 @@ class DreamFusionModel(Model): def update_target_transmittance( self, training_callback_attributes: TrainingCallbackAttributes, step: int # pylint: disable=unused-argument ): - self.target_transmittance -= (1 / self.config.transmittance_end_schedule) * ( - self.config.target_transmittance_start - self.config.target_transmittance_end - ) + if step < self.config.transmittance_end_schedule: + self.target_transmittance -= (1 / self.config.transmittance_end_schedule) * ( + self.config.target_transmittance_start - self.config.target_transmittance_end + ) callbacks = [ TrainingCallback( @@ -156,7 +157,7 @@ class DreamFusionModel(Model): ), TrainingCallback( where_to_run=[TrainingCallbackLocation.AFTER_TRAIN_ITERATION], - iters=(self.config.transmittance_end_schedule,), + update_every_num_iters=1, func=update_target_transmittance, args=[self, training_callback_attributes], ),