From 581ba95eabec3057b477824c87b7dba6fcc565f9 Mon Sep 17 00:00:00 2001 From: Hardik Dava <39372750+hardikdava@users.noreply.github.com> Date: Mon, 8 Jan 2024 19:19:38 +0100 Subject: [PATCH] fixed not cache images for full image datamanager (#2692) * rm no-cache option --------- Co-authored-by: Matias Turkulainen <30566358+maturk@users.noreply.github.com> Co-authored-by: maturk Co-authored-by: Justin Kerr --- nerfstudio/data/datamanagers/full_images_datamanager.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/nerfstudio/data/datamanagers/full_images_datamanager.py b/nerfstudio/data/datamanagers/full_images_datamanager.py index 83bdfc679..92d65478c 100644 --- a/nerfstudio/data/datamanagers/full_images_datamanager.py +++ b/nerfstudio/data/datamanagers/full_images_datamanager.py @@ -59,8 +59,8 @@ class FullImageDatamanagerConfig(DataManagerConfig): new images. If -1, never pick new images.""" eval_image_indices: Optional[Tuple[int, ...]] = (0,) """Specifies the image indices to use during eval; if None, uses all.""" - cache_images: Literal["no-cache", "cpu", "gpu"] = "cpu" - """Whether to cache images in memory. If "numpy", caches as numpy arrays, if "torch", caches as torch tensors.""" + cache_images: Literal["cpu", "gpu"] = "cpu" + """Whether to cache images in memory. If "cpu", caches on cpu. If "gpu", caches on device.""" class FullImageDatamanager(DataManager, Generic[TDataset]): @@ -122,6 +122,7 @@ class FullImageDatamanager(DataManager, Generic[TDataset]): def cache_images(self, cache_images_option): cached_train = [] + cached_eval = [] CONSOLE.log("Caching / undistorting train images") for i in tqdm(range(len(self.train_dataset)), leave=False): # cv2.undistort the images / cameras @@ -195,7 +196,6 @@ class FullImageDatamanager(DataManager, Generic[TDataset]): self.train_dataset.cameras.cx[i] = float(K[0, 2]) self.train_dataset.cameras.cy[i] = float(K[1, 2]) - cached_eval = [] CONSOLE.log("Caching / undistorting eval images") for i in tqdm(range(len(self.eval_dataset)), leave=False): # cv2.undistort the images / cameras