diff --git a/nerfstudio/models/nerfacto.py b/nerfstudio/models/nerfacto.py index 11adadbd7..4e619ad21 100644 --- a/nerfstudio/models/nerfacto.py +++ b/nerfstudio/models/nerfacto.py @@ -67,7 +67,7 @@ class NerfactoModelConfig(ModelConfig): """How far along the ray to start sampling.""" far_plane: float = 1000.0 """How far along the ray to stop sampling.""" - background_color: Literal["background", "last_sample"] = "last_sample" + background_color: Literal["random", "last_sample"] = "last_sample" """Whether to randomize the background color.""" num_levels: int = 16 """Number of levels of the hashmap for the base mlp.""" @@ -75,8 +75,8 @@ class NerfactoModelConfig(ModelConfig): """Maximum resolution of the hashmap for the base mlp.""" log2_hashmap_size: int = 19 """Size of the hashmap for the base mlp""" - num_proposal_samples_per_ray: Tuple[int] = (256, 96) - """Number of samples per ray for the proposal network.""" + num_proposal_samples_per_ray: Tuple[int, ...] = (256, 96) + """Number of samples per ray for each proposal network.""" num_nerf_samples_per_ray: int = 48 """Number of samples per ray for the nerf network.""" proposal_update_every: int = 5 diff --git a/scripts/exporter.py b/scripts/exporter.py index 658d5e191..175cee187 100644 --- a/scripts/exporter.py +++ b/scripts/exporter.py @@ -57,7 +57,7 @@ class ExportPointCloud(Exporter): bounding_box_min: Tuple[float, float, float] = (-1, -1, -1) """Minimum of the bounding box, used if use_bounding_box is True.""" bounding_box_max: Tuple[float, float, float] = (1, 1, 1) - """Minimum of the bounding box, used if use_bounding_box is True.""" + """Maximum of the bounding box, used if use_bounding_box is True.""" num_rays_per_batch: int = 32768 """Number of rays to evaluate per batch. Decrease if you run out of memory.""" std_ratio: float = 10.0 @@ -314,18 +314,20 @@ class ExportMarchingCubesMesh(Exporter): raise NotImplementedError("Marching cubes not implemented yet.") -Commands = Union[ - Annotated[ExportPointCloud, tyro.conf.subcommand(name="pointcloud")], - Annotated[ExportTSDFMesh, tyro.conf.subcommand(name="tsdf")], - Annotated[ExportPoissonMesh, tyro.conf.subcommand(name="poisson")], - Annotated[ExportMarchingCubesMesh, tyro.conf.subcommand(name="marching-cubes")], +Commands = tyro.conf.FlagConversionOff[ + Union[ + Annotated[ExportPointCloud, tyro.conf.subcommand(name="pointcloud")], + Annotated[ExportTSDFMesh, tyro.conf.subcommand(name="tsdf")], + Annotated[ExportPoissonMesh, tyro.conf.subcommand(name="poisson")], + Annotated[ExportMarchingCubesMesh, tyro.conf.subcommand(name="marching-cubes")], + ] ] def entrypoint(): """Entrypoint for use with pyproject scripts.""" tyro.extras.set_accent_color("bright_yellow") - tyro.cli(tyro.conf.FlagConversionOff[Commands]).main() + tyro.cli(Commands).main() if __name__ == "__main__":