From 4c2e200098dda1c7afea38ec8e7eb92ae5938d21 Mon Sep 17 00:00:00 2001 From: David McAllister Date: Wed, 15 Mar 2023 20:27:37 -0700 Subject: [PATCH] TensoRF go brrrrrrr (#1609) * pdfsampler no longer includes uniform samples * Lint * Typo fix --------- Co-authored-by: Matthew Tancik --- nerfstudio/configs/method_configs.py | 2 ++ nerfstudio/models/tensorf.py | 9 +++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/nerfstudio/configs/method_configs.py b/nerfstudio/configs/method_configs.py index 5d799fb01..22635a911 100644 --- a/nerfstudio/configs/method_configs.py +++ b/nerfstudio/configs/method_configs.py @@ -310,6 +310,8 @@ method_configs["tensorf"] = TrainerConfig( pipeline=VanillaPipelineConfig( datamanager=VanillaDataManagerConfig( dataparser=BlenderDataParserConfig(), + train_num_rays_per_batch=4096, + eval_num_rays_per_batch=4096, ), model=TensoRFModelConfig(), ), diff --git a/nerfstudio/models/tensorf.py b/nerfstudio/models/tensorf.py index 3b27354d1..2da35f5d1 100644 --- a/nerfstudio/models/tensorf.py +++ b/nerfstudio/models/tensorf.py @@ -70,8 +70,10 @@ class TensoRFModelConfig(ModelConfig): """specifies a list of iteration step numbers to perform upsampling""" loss_coefficients: Dict[str, float] = to_immutable_dict({"rgb_loss": 1.0}) """Loss specific weights.""" - num_samples: int = 256 + num_samples: int = 50 """Number of samples in field evaluation""" + num_uniform_samples: int = 200 + """Number of samples in density evaluation""" num_den_components: int = 16 """Number of components in density encoding""" num_color_components: int = 48 @@ -116,7 +118,6 @@ class TensoRFModel(Model): def get_training_callbacks( self, training_callback_attributes: TrainingCallbackAttributes ) -> List[TrainingCallback]: - # the callback that we want to run every X iterations after the training iteration def reinitialize_optimizer( self, training_callback_attributes: TrainingCallbackAttributes, step: int # pylint: disable=unused-argument @@ -219,8 +220,8 @@ class TensoRFModel(Model): ) # samplers - self.sampler_uniform = UniformSampler(num_samples=self.config.num_samples, single_jitter=True) - self.sampler_pdf = PDFSampler(num_samples=self.config.num_samples // 2, single_jitter=True) + self.sampler_uniform = UniformSampler(num_samples=self.config.num_uniform_samples, single_jitter=True) + self.sampler_pdf = PDFSampler(num_samples=self.config.num_samples, single_jitter=True, include_original=False) # renderers self.renderer_rgb = RGBRenderer(background_color=colors.WHITE)