From 3a056ed622e7e302d32d7e28d5b9bb63bc8cace9 Mon Sep 17 00:00:00 2001
From: Abhik Ahuja <ahujaabhik@berkeley.edu>
Date: Mon, 7 Nov 2022 22:45:00 -0800
Subject: [PATCH] Fixed crash when camera looping is on, but no cameras (#922)

Fixed camera cycle crash
---
 .../SidePanel/CameraPanel/CameraPanel.jsx     | 78 ++++++++++++-------
 .../modules/SidePanel/CameraPanel/curve.js    |  9 +--
 2 files changed, 55 insertions(+), 32 deletions(-)

diff --git a/nerfstudio/viewer/app/src/modules/SidePanel/CameraPanel/CameraPanel.jsx b/nerfstudio/viewer/app/src/modules/SidePanel/CameraPanel/CameraPanel.jsx
index ec252234f..dbabf0f3d 100644
--- a/nerfstudio/viewer/app/src/modules/SidePanel/CameraPanel/CameraPanel.jsx
+++ b/nerfstudio/viewer/app/src/modules/SidePanel/CameraPanel/CameraPanel.jsx
@@ -87,16 +87,19 @@ function FovSelector(props) {
     const new_focal_len = camera.getFocalLength();
     camera.fov = old_fov;
     const label = Math.round(
-      fovLabel === FOV_LABELS.FOV
-        ? globalFov
-        : new_focal_len * camera.aspect,
+      fovLabel === FOV_LABELS.FOV ? globalFov : new_focal_len * camera.aspect,
     );
     return label;
   };
 
-  const [UIFieldOfView, setUIFieldOfView] = React.useState(isGlobal ? globalFov : getFovLabel());
+  const [UIFieldOfView, setUIFieldOfView] = React.useState(
+    isGlobal ? globalFov : getFovLabel(),
+  );
 
-  useEffect(() => setUIFieldOfView(getFovLabel()), [camera, fovLabel, globalFov]);
+  useEffect(
+    () => setUIFieldOfView(getFovLabel()),
+    [camera, fovLabel, globalFov],
+  );
 
   const setFOV = (val) => {
     if (!isGlobal) {
@@ -109,10 +112,10 @@ function FovSelector(props) {
       setGlobalFov(val);
     } else {
       const old_fov = camera.fov;
-        camera.setFocalLength(val / camera.aspect);
-        const new_fov = camera.getEffectiveFOV();
-        camera.fov = old_fov;
-        setGlobalFov(new_fov);
+      camera.setFocalLength(val / camera.aspect);
+      const new_fov = camera.getEffectiveFOV();
+      camera.fov = old_fov;
+      setGlobalFov(new_fov);
     }
 
     if (applyAll) {
@@ -178,8 +181,10 @@ function FovSelector(props) {
       }}
       sx={{
         input: {
-          "-webkit-text-fill-color": `${disabled ? "#24B6FF" : "#EBEBEB"} !important`,
-          color: `${disabled ? "#24B6FF" : "#EBEBEB"} !important`,
+          '-webkit-text-fill-color': `${
+            disabled ? '#24B6FF' : '#EBEBEB'
+          } !important`,
+          color: `${disabled ? '#24B6FF' : '#EBEBEB'} !important`,
         },
       }}
       value={UIFieldOfView}
@@ -391,21 +396,22 @@ function CameraList(props) {
           </Stack>
         </AccordionSummary>
         <AccordionDetails>
-          {isAnimated('FOV') &&
-          <FovSelector
-            fovLabel={fovLabel}
-            setFovLabel={setFovLabel}
-            camera={camera}
-            dispatch={dispatch}
-            disabled={!isAnimated('FOV')}
-            isGlobal={false}
-            changeMain={false}
-          />}
-          {!isAnimated('FOV') &&
-           <p style={{ fontSize: 'smaller', color: '#999999' }}>
+          {isAnimated('FOV') && (
+            <FovSelector
+              fovLabel={fovLabel}
+              setFovLabel={setFovLabel}
+              camera={camera}
+              dispatch={dispatch}
+              disabled={!isAnimated('FOV')}
+              isGlobal={false}
+              changeMain={false}
+            />
+          )}
+          {!isAnimated('FOV') && (
+            <p style={{ fontSize: 'smaller', color: '#999999' }}>
               Animated camera properties will show up here!
             </p>
-          }
+          )}
         </AccordionDetails>
       </Accordion>
     );
@@ -721,7 +727,7 @@ export default function CameraPanel(props) {
     values.push(is_cycle ? time * ratio : time);
   });
 
-  if (is_cycle) {
+  if (is_cycle && cameras.length !== 0) {
     values.push(1.0);
   }
 
@@ -1110,12 +1116,27 @@ export default function CameraPanel(props) {
             onClick={() => {
               toggleAnimate('FOV');
             }}
-            style={{maxWidth: '20px', maxHeight: '20px', minWidth: '20px', minHeight: '20px', position: 'relative', top: '22px'}}
+            style={{
+              maxWidth: '20px',
+              maxHeight: '20px',
+              minWidth: '20px',
+              minHeight: '20px',
+              position: 'relative',
+              top: '22px',
+            }}
             sx={{
               mt: 1,
             }}
           >
-            <Animation style={{color: isAnimated('FOV') ? "#24B6FF" : "#EBEBEB", maxWidth: '20px', maxHeight: '20px', minWidth: '20px', minHeight: '20px'}}/>
+            <Animation
+              style={{
+                color: isAnimated('FOV') ? '#24B6FF' : '#EBEBEB',
+                maxWidth: '20px',
+                maxHeight: '20px',
+                minWidth: '20px',
+                minHeight: '20px',
+              }}
+            />
           </Button>
         </Tooltip>
         <FovSelector
@@ -1222,6 +1243,9 @@ export default function CameraPanel(props) {
           step={step_size}
           valueLabelDisplay="auto"
           valueLabelFormat={(value, i) => {
+            if (cameras.length === 0) {
+              return '';
+            }
             if (i === cameras.length && is_cycle) {
               return `${cameras[0].properties.get('NAME')} @ ${parseFloat(
                 (value * seconds).toFixed(2),
diff --git a/nerfstudio/viewer/app/src/modules/SidePanel/CameraPanel/curve.js b/nerfstudio/viewer/app/src/modules/SidePanel/CameraPanel/curve.js
index e877cbf4e..11a36f7cf 100644
--- a/nerfstudio/viewer/app/src/modules/SidePanel/CameraPanel/curve.js
+++ b/nerfstudio/viewer/app/src/modules/SidePanel/CameraPanel/curve.js
@@ -19,6 +19,9 @@ export function get_curve_object_from_cameras(
   is_cycle,
   smoothness_value,
 ) {
+  if (cameras.length === 0) {
+    return null;
+  }
   // interpolate positions, lookat directions, and ups
   // similar to
   // https://github.com/google-research/multinerf/blob/1c8b1c552133cdb2de1c1f3c871b2813f6662265/internal/camera_utils.py#L281
@@ -64,11 +67,7 @@ export function get_curve_object_from_cameras(
   let curve_ups = null;
   let curve_fovs = null;
 
-  curve_positions = get_catmull_rom_curve(
-    positions,
-    false,
-    smoothness_value,
-  );
+  curve_positions = get_catmull_rom_curve(positions, false, smoothness_value);
   curve_lookats = get_catmull_rom_curve(lookats, false, smoothness_value);
   curve_ups = get_catmull_rom_curve(ups, false, smoothness_value);
   curve_fovs = get_catmull_rom_curve(fovs, false, 0.05);