mirror of
https://github.com/nerfstudio-project/nerfstudio.git
synced 2026-11-21 23:25:39 +08:00
Final typing fixes + add Pyright to CI (#1944)
* knocking out a couple * Fix more errors * Add pyright * Remove some unnecessary cv2 type ignores, warning on missing imports (for missing tinycudann) * Minor annotation fixes * Update docs * Drop `None` from temporal distortion output --------- Co-authored-by: Brent Yi <yibrenth@gmail.com>
This commit is contained in:
1 parent
08e3a1f1a6
commit
2b0831b6d4
28 files changed
+110
-71
No files matched your search
@@ -18,6 +18,7 @@ Below are the various tooling features our team uses to maintain this codebase.
|
||||
| --------------- | ---------------------------------------------------------- |
|
||||
| Formatting | [Black](https://black.readthedocs.io/en/stable/) |
|
||||
| Linter | [Ruff](https://beta.ruff.rs/docs/) |
|
||||
| Type checking | [Pyright](https://github.com/microsoft/pyright) |
|
||||
| Testing | [pytest](https://docs.pytest.org/en/7.1.x/) |
|
||||
| Docs | [Sphinx](https://www.sphinx-doc.org/en/master/) |
|
||||
| Docstring style | [Google](https://google.github.io/styleguide/pyguide.html) |
|
||||
@@ -53,7 +54,8 @@ conda install -c conda-forge pandoc
|
||||
|
||||
This will perform the following checks and actions:
|
||||
|
||||
- Black/ Linting style check: Ensures code is consistently and properly formatted.
|
||||
- Formatting and linting: Ensures code is consistently and properly formatted.
|
||||
- Type checking: Ensures static type safety.
|
||||
- Pytests: Runs pytests locally to make sure added code does not break existing logic.
|
||||
- Documentation build: Builds docs locally. Ensures changes do not result in warnings/errors.
|
||||
- Licensing: Automatically adds licensing headers to the correct files.
|
||||
|
||||
Reference in new issue
Block a user