From 18a6a71a1a0b5251bc514f971cb42f93129f5f40 Mon Sep 17 00:00:00 2001 From: Alexander Kristoffersen Date: Tue, 25 Oct 2022 10:01:39 -0700 Subject: [PATCH] Pathlib Python 3.7 Compatibility Fix (#831) small fix. --- scripts/downloads/download_data.py | 6 ++++-- scripts/process_data.py | 5 ++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/scripts/downloads/download_data.py b/scripts/downloads/download_data.py index aa96b25c1..5a8c80727 100755 --- a/scripts/downloads/download_data.py +++ b/scripts/downloads/download_data.py @@ -32,7 +32,8 @@ def download_blender(save_dir: Path): unzip_path = save_dir / Path("nerf_synthetic") final_path = save_dir / Path("blender") unzip_path.rename(final_path) - download_path.unlink(missing_ok=True) + if download_path.exists(): + download_path.unlink() def download_friends(save_dir: Path): @@ -123,7 +124,8 @@ def download_dnerf(save_dir: Path): unzip_path = save_dir / Path("data") final_path = save_dir / Path("dnerf") unzip_path.rename(final_path) - download_path.unlink(missing_ok=True) + if download_path.exists(): + download_path.unlink() def main( diff --git a/scripts/process_data.py b/scripts/process_data.py index d3e8263a2..91074938b 100755 --- a/scripts/process_data.py +++ b/scripts/process_data.py @@ -345,7 +345,10 @@ def run_colmap( colmap_version = get_colmap_version() - (colmap_dir / "database.db").unlink(missing_ok=True) + colmap_database_path = colmap_dir / "database.db" + if colmap_database_path.exists(): + # Can't use missing_ok argument because of Python 3.7 compatibility. + colmap_database_path.unlink() # Feature extraction feature_extractor_cmd = [