From 0a9eb8a7c9ab080452cb7491aeae73e9dabf711f Mon Sep 17 00:00:00 2001 From: Justin Date: Sun, 18 Jun 2023 05:01:07 +0000 Subject: [PATCH] cleanup --- nerfstudio/configs/method_configs.py | 2 +- nerfstudio/engine/trainer.py | 1 - nerfstudio/viewer_beta/render_state_machine.py | 1 - nerfstudio/viewer_beta/viewer.py | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/nerfstudio/configs/method_configs.py b/nerfstudio/configs/method_configs.py index 7c2253f0c..aa5eb0f67 100644 --- a/nerfstudio/configs/method_configs.py +++ b/nerfstudio/configs/method_configs.py @@ -89,7 +89,7 @@ method_configs["nerfacto"] = TrainerConfig( eval_num_rays_per_batch=4096, camera_optimizer=CameraOptimizerConfig( mode="SO3xR3", - optimizer=AdamOptimizerConfig(lr=6e-4, eps=1e-8, weight_decay=0), + optimizer=AdamOptimizerConfig(lr=6e-4, eps=1e-8, weight_decay=1e-2), scheduler=ExponentialDecaySchedulerConfig(lr_final=6e-6, max_steps=200000), ), ), diff --git a/nerfstudio/engine/trainer.py b/nerfstudio/engine/trainer.py index a9bb876c2..afc0d94f3 100644 --- a/nerfstudio/engine/trainer.py +++ b/nerfstudio/engine/trainer.py @@ -351,7 +351,6 @@ class Trainer: except RuntimeError: time.sleep(0.03) # sleep to allow buffer to reset CONSOLE.log("Viewer failed. Continuing training.") - raise @check_viewer_enabled def _train_complete_viewer(self) -> None: diff --git a/nerfstudio/viewer_beta/render_state_machine.py b/nerfstudio/viewer_beta/render_state_machine.py index c56994a41..0b00f4dac 100644 --- a/nerfstudio/viewer_beta/render_state_machine.py +++ b/nerfstudio/viewer_beta/render_state_machine.py @@ -107,7 +107,6 @@ class RenderStateMachine(threading.Thread): # handle interrupt logic if self.state == "high" and self.next_action.action in ("move", "rerender"): - print("interrupting render", self.next_action.action) self.interrupt_render_flag = True self.render_trigger.set() diff --git a/nerfstudio/viewer_beta/viewer.py b/nerfstudio/viewer_beta/viewer.py index af08bbcc3..fdc0f21cc 100644 --- a/nerfstudio/viewer_beta/viewer.py +++ b/nerfstudio/viewer_beta/viewer.py @@ -218,7 +218,6 @@ class Viewer: image=image_uint8, wxyz=R.wxyz, position=c2w[:3, 3] * VISER_NERFSTUDIO_SCALE_RATIO, - jpeg_quality=50, ) @camera_handle.on_click